New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: the terminal refine linter #11890
Open
adomani
wants to merge
13
commits into
master
Choose a base branch
from
adomani/terminal_refine_linter
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+279
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!bench |
Here are the benchmark results for commit 5f02e63. Benchmark Metric Change
==============================================================================
+ build linting -5.2%
+ ~Mathlib.AlgebraicGeometry.Morphisms.RingHomProperties instructions -4.2% |
adomani
added
awaiting-review
The author would like community review of the PR
t-linter
Linter
labels
Apr 4, 2024
Do not be fooled by the green: the PR is largely a slowdown! |
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 5, 2024
leanprover-community-mathlib4-bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 5, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
See #11890 and this [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Usage.20of.20refine') for an in-depth explanation of why these `refine`s and not others. The short answer is that the files in which these replacements took place were more performant after the change than before.
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 5, 2024
leanprover-community-mathlib4-bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 5, 2024
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
See #11890 and this [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Usage.20of.20refine') for an in-depth explanation of why these `refine`s and not others. The short answer is that the files in which these replacements took place were more performant after the change than before.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
See #11890 and this [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Usage.20of.20refine') for an in-depth explanation of why these `refine`s and not others. The short answer is that the files in which these replacements took place were more performant after the change than before.
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 17, 2024
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
See #11890 and this [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Usage.20of.20refine') for an in-depth explanation of why these `refine`s and not others. The short answer is that the files in which these replacements took place were more performant after the change than before.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
See #11890 and this [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Usage.20of.20refine') for an in-depth explanation of why these `refine`s and not others. The short answer is that the files in which these replacements took place were more performant after the change than before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-review
The author would like community review of the PR
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
t-linter
Linter
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A linter that warns on usages of
refine
andrefine'
as a finishing tactic.See this Zulip discussion.
Conclusion of the experiment
Systematic replacements of terminal
refine
withexact
leads to an overall slow-down.