[Merged by Bors] - doc(Algebra/Ring): add docstring for CommRing and CommSemiring
#11894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR resolves some nolints by adding docstrings for `CommRing` and `CommSemiring`.
pitmonticone
added
documentation
pitmonticone
changed the title
CommRing and CommSemiringCommRing and CommSemiring
eric-wieser
reviewed
Apr 4, 2024
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Done @eric-wieser |
|
These docstrings existed in Lean 3. Can you see what they were? |
Do you mean these? @YaelDillies |
|
Yep! |
|
Ok, should I copy-paste them here with the obvious minor adjustments or those committed in this PR are fine? |
YaelDillies
reviewed
Apr 4, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Done @YaelDillies |
YaelDillies
approved these changes
Apr 4, 2024
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
Please merge when CI clears. Thanks. bors delegate+ |
|
✌️ pitmonticone can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
…11894) This PR resolves some nolints by adding docstrings for `CommRing` and `CommSemiring`.
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
bors merge |
|
Already running a review |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
CommRing and CommSemiringCommRing and CommSemiring
grunweg
pushed a commit
that referenced
this pull request
Apr 4, 2024
…11894) This PR resolves some nolints by adding docstrings for `CommRing` and `CommSemiring`.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
…11894) This PR resolves some nolints by adding docstrings for `CommRing` and `CommSemiring`.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
…11894) This PR resolves some nolints by adding docstrings for `CommRing` and `CommSemiring`.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
…11894) This PR resolves some nolints by adding docstrings for `CommRing` and `CommSemiring`.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
…11894) This PR resolves some nolints by adding docstrings for `CommRing` and `CommSemiring`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves some nolints by adding docstrings for
CommRingandCommSemiring.