[Merged by Bors] - style: fix references to DenselyOrdered #11897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-manthe
added
awaiting-review
github-actions
bot
added
the
new-contributor
grunweg
approved these changes
Apr 4, 2024
| @@ -153,15 +153,15 @@ instance denselyOrdered_of_noMaxOrder [Preorder ι] [∀ i, Preorder (α i)] | |||
| exact ⟨⟨i, c⟩, right _ ha, right _ hb⟩⟩ | |||
| #align psigma.lex.densely_ordered_of_no_max_order PSigma.Lex.denselyOrdered_of_noMaxOrder | |||
|
|
|||
| instance densely_ordered_of_noMinOrder [Preorder ι] [∀ i, Preorder (α i)] | |||
| instance denselyOrdered_of_noMinOrder [Preorder ι] [∀ i, Preorder (α i)] | |||
There was a problem hiding this comment.
I believe the naming convention is that manual instance names should start with "inst", i.e.
Suggested change
| instance denselyOrdered_of_noMinOrder [Preorder ι] [∀ i, Preorder (α i)] | |
| instance instDenselyOrdered_of_noMinOrder [Preorder ι] [∀ i, Preorder (α i)] |
(I'm not 100% sure on the casing; you may want to compare with other names/wait for another pair of eyes.)
There was a problem hiding this comment.
If I do this, there will be many more examples of such instances in this file alone
There was a problem hiding this comment.
Sure; mathlib is not always consistent (and I think a fix for that would be welcome - to be sure, I'd ask on zulip first).
I'm not asking you to change any other instances! But when you're renaming this one, I'd rather rename it to a "right" than a "less wrong" name.
There was a problem hiding this comment.
Personally, I would find the resulting inconsistency with e.g. denselyOrdered_of_noMaxOrder even more confusing
Co-authored-by: grunweg <rothgami@math.hu-berlin.de>
…_ordered' into sven-naming-densely_ordered
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
Rename occurrences of "densely_ordered" to "denselyOrdered" Co-authored-by: sven-manthe <147848313+sven-manthe@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
Rename occurrences of "densely_ordered" to "denselyOrdered" Co-authored-by: sven-manthe <147848313+sven-manthe@users.noreply.github.com>
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Rename occurrences of "densely_ordered" to "denselyOrdered" Co-authored-by: sven-manthe <147848313+sven-manthe@users.noreply.github.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Rename occurrences of "densely_ordered" to "denselyOrdered" Co-authored-by: sven-manthe <147848313+sven-manthe@users.noreply.github.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Rename occurrences of "densely_ordered" to "denselyOrdered" Co-authored-by: sven-manthe <147848313+sven-manthe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename occurrences of "densely_ordered" to "denselyOrdered"