[Merged by Bors] - feat: add Inv, Abs, and natAbs positivity extensions #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
dwrensha
added
the
awaiting-review
digama0
reviewed
Dec 23, 2022
Mathlib/Tactic/Positivity/Basic.lean
Outdated
|
|
||
| /-- Port note: in mathlib3 this alias is `private`, but mathlib4's `alias` does not | ||
| (yet) support that. -/ | ||
| alias abs_pos ↔ _ abs_pos_of_ne_zero |
There was a problem hiding this comment.
Mathlib3's alias doesn't support private either. I think the statement should just be written out.
There was a problem hiding this comment.
Done -- rewritten as a private theroem.
digama0
reviewed
Dec 23, 2022
Mathlib/Tactic/Positivity/Basic.lean
Outdated
| alias abs_pos ↔ _ abs_pos_of_ne_zero | ||
|
|
||
| /-- The `positivity` extension which identifies expressions of the form `|a|`. -/ | ||
| @[positivity |(_ : α)|, Abs.abs _] |
There was a problem hiding this comment.
These two patterns are the same. The reason add and mul have two patterns instead of one is because they match both HAdd.hAdd and Add.add.
There was a problem hiding this comment.
Done, and similar for evalInv.
dwrensha
changed the title
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 5, 2023
Adds `positivity` extensions for inversion, absolute value, and natAbs. Compare the the mathlib3 versions [here](https://github.com/leanprover-community/mathlib/blob/3813d4ea1c6a34dbb472de66e73b8c6855b03964/src/tactic/positivity.lean#L535-L546), [here](https://github.com/leanprover-community/mathlib/blob/3813d4ea1c6a34dbb472de66e73b8c6855b03964/src/tactic/positivity.lean#L616-L631), and [here](https://github.com/leanprover-community/mathlib/blob/09258fb7f75d741b7eda9fa18d5c869e2135d9f1/src/tactic/positivity.lean#L633-L650). For the absolute value case, I got stuck trying to make it work in the fully `Qq`-ified style, so I fell back to the `AppBuilder` style that's closer to how mathlib3 does it.
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
positivityextensions for inversion, absolute value, and natAbs.Compare the the mathlib3 versions here, here, and here.
For the absolute value case, I got stuck trying to make it work in the fully
Qq-ified style, so I fell back to theAppBuilderstyle that's closer to how mathlib3 does it.