[Merged by Bors] - chore: refactor to avoid importing Ring for Group topics #11913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
awaiting-review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
(I had more than once traversed these files while creating minimisations, and been annoyed by the spurious imports here!) |
YaelDillies
reviewed
Apr 5, 2024
leanprover-community-mathlib4-bot
added
the
merge-conflict
|
Nevermind, I split that off to #11924. |
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
|
@YaelDillies, I've delegated your #11924. Do you think I could leave it to you to merge master into this, once it is in? |
leanprover-community-mathlib4-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
…hen_talking_about_groups
leanprover-community-mathlib4-bot
added
merge-conflict
semorrison
removed
the
merge-conflict
…hen_talking_about_groups
|
maintainer merge |
1 similar comment
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
leanprover-community-mathlib4-bot
removed
the
merge-conflict
adomani
reviewed
Apr 20, 2024
|
|
||
| variable {R : Type*} [Semiring R] (f : R →+* R) (n : ℕ) (x y : R) | ||
|
|
||
| theorem coe_pow (n : ℕ) : ⇑(f ^ n) = f^[n] := |
There was a problem hiding this comment.
According to an automated diff, this seems to be the only lemma that disappeared in this PR.
|
bors d+ |
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2024
This is a far from a complete success at the PR title, but it makes a fair bit of progress, and then guards this with appropriate `assert_not_exists Ring` statements. It also breaks apart the `Mathlib.GroupTheory.Subsemigroup.[Center|Centralizer]` files, to pull the `Set.center` and `Set.centralizer` declarations into their own files not depending on `Subsemigroup`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Build failed: |
…hen_talking_about_groups
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2024
This is a far from a complete success at the PR title, but it makes a fair bit of progress, and then guards this with appropriate `assert_not_exists Ring` statements. It also breaks apart the `Mathlib.GroupTheory.Subsemigroup.[Center|Centralizer]` files, to pull the `Set.center` and `Set.centralizer` declarations into their own files not depending on `Subsemigroup`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
mathlib-bors
bot
deleted the
dont_import_rings_when_talking_about_groups
branch
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
This is a far from a complete success at the PR title, but it makes a fair bit of progress, and then guards this with appropriate `assert_not_exists Ring` statements. It also breaks apart the `Mathlib.GroupTheory.Subsemigroup.[Center|Centralizer]` files, to pull the `Set.center` and `Set.centralizer` declarations into their own files not depending on `Subsemigroup`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
This is a far from a complete success at the PR title, but it makes a fair bit of progress, and then guards this with appropriate `assert_not_exists Ring` statements. It also breaks apart the `Mathlib.GroupTheory.Subsemigroup.[Center|Centralizer]` files, to pull the `Set.center` and `Set.centralizer` declarations into their own files not depending on `Subsemigroup`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a far from a complete success at the PR title, but it makes a fair bit of progress, and then guards this with appropriate
assert_not_exists Ringstatements.It also breaks apart the
Mathlib.GroupTheory.Subsemigroup.[Center|Centralizer]files, to pull theSet.centerandSet.centralizerdeclarations into their own files not depending onSubsemigroup.Data.{Nat,Int}{.Order}.Basicin group vs ring instances #11924