[Merged by Bors] - chore: Slightly modify the split of CanonicalEmbedding
#11917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xroblot
added
awaiting-review
Ruben-VandeVelde
approved these changes
Apr 5, 2024
| @@ -507,5 +507,3 @@ theorem mem_span_fractionalIdealLatticeBasis (x : (E K)) : | |||
| rfl | |||
|
|
|||
| end integerLattice | |||
|
|
|||
| end NumberField.mixedEmbedding | |||
There was a problem hiding this comment.
I know it's not necessary, strictly speaking, but I'd keep this line.
fpvandoorn
reviewed
Apr 5, 2024
| The canonical embedding of a number field `K` of degree `n` is the ring homomorphism | ||
| `K →+* ℂ^n` that sends `x ∈ K` to `(φ_₁(x),...,φ_n(x))` where the `φ_i`'s are the complex | ||
| embeddings of `K`. Note that we do not choose an ordering of the embeddings, but instead map `K` | ||
| into the type `(K →+* ℂ) → ℂ` of `ℂ`-vectors indexed by the complex embeddings. |
There was a problem hiding this comment.
Was this intentionally duplicated from the Basic file?
There was a problem hiding this comment.
Yeah, you're right, that's not optimal. I'll change to a better docstring. Thanks
|
✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors + |
|
Did you mean "r+"? |
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
Create a new directory for the split of `CanonicalEmbedding` since more material is coming. Also add some docstrings.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
CanonicalEmbeddingCanonicalEmbedding
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
Create a new directory for the split of `CanonicalEmbedding` since more material is coming. Also add some docstrings.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Create a new directory for the split of `CanonicalEmbedding` since more material is coming. Also add some docstrings.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Create a new directory for the split of `CanonicalEmbedding` since more material is coming. Also add some docstrings.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Create a new directory for the split of `CanonicalEmbedding` since more material is coming. Also add some docstrings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new directory for the split of
CanonicalEmbeddingsince more material is coming.Also add some docstrings.