Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(RingTheory/Kaehler): The exact sequence B ⊗[A] Ω[A⁄R] → Ω[B⁄R] → Ω[B⁄A] → 0. #11925

Closed
wants to merge 10 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Apr 5, 2024


Open in Gitpod

@erdOne erdOne added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Apr 5, 2024
@riccardobrasca riccardobrasca self-assigned this Apr 14, 2024
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have enough technology to use CategoryTheory.ShortComplex.ShortExact or something like that? I mean, literally saying the sequence is exact.

Mathlib/RingTheory/Kaehler.lean Show resolved Hide resolved
Mathlib/RingTheory/Kaehler.lean Outdated Show resolved Hide resolved
@erdOne erdOne added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 14, 2024
@joelriou
Copy link
Collaborator

joelriou commented Apr 22, 2024

Do we have enough technology to use CategoryTheory.ShortComplex.ShortExact or something like that? I mean, literally saying the sequence is exact.

In general, we cannot use category theory here because of heterogeneous universes. Eventually, it may be useful to state exactness (by saying that a certain cokernel cofork is colimit) when all the modules are in the same universe, but I do not feel it has to be done in this PR. (It would be an application of https://leanprover-community.github.io/mathlib4_docs/Mathlib/Algebra/Homology/ShortComplex/ModuleCat.html#CategoryTheory.ShortComplex.moduleCat_exact_iff_range_eq_ker)

Exactness could also be formulated also using the basic API in Mathlib.Algebra.Exact which allow different universes.

@riccardobrasca
Copy link
Member

Can you add a short docstring as I wrote above? Anyway thanks a lot!

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Apr 28, 2024

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@erdOne
Copy link
Member Author

erdOne commented Apr 28, 2024

Sorry it took so long to fix. I've incorporated some suggestions above and a few more and maybe @riccardobrasca can give it a final look before I send it to bors?

@riccardobrasca
Copy link
Member

Sorry it took so long to fix. I've incorporated some suggestions above and a few more and maybe @riccardobrasca can give it a final look before I send it to bors?

I am boarding on a long flight, I can have a look tomorrow.

@erdOne erdOne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 28, 2024
@riccardobrasca
Copy link
Member

It still looks good, thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 29, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 29, 2024
…→ Ω[B⁄A] → 0`. (#11925)

Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 29, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/Kaehler): The exact sequence B ⊗[A] Ω[A⁄R] → Ω[B⁄R] → Ω[B⁄A] → 0. [Merged by Bors] - feat(RingTheory/Kaehler): The exact sequence B ⊗[A] Ω[A⁄R] → Ω[B⁄R] → Ω[B⁄A] → 0. Apr 29, 2024
@mathlib-bors mathlib-bors bot closed this Apr 29, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/kaehlerexact branch April 29, 2024 06:58
apnelson1 pushed a commit that referenced this pull request May 12, 2024
…→ Ω[B⁄A] → 0`. (#11925)

Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
callesonne pushed a commit that referenced this pull request May 16, 2024
…→ Ω[B⁄A] → 0`. (#11925)

Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants