[Merged by Bors] - feat: port Control.Fix #1194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shreyas4991
added
awaiting-review
arienmalec
approved these changes
Dec 24, 2022
Mathlib/Control/Fix.lean
Outdated
| @@ -67,22 +67,22 @@ it satisfies the equations: | |||
| 1. `fix f = f (fix f)` (is a fixed point) | |||
| 2. `∀ X, f X ≤ X → fix f ≤ X` (least fixed point) | |||
| -/ | |||
| protected def fix (x : α) : Part <| β x := | |||
| protected noncomputable def fix (x : α) : Part <| β x := | |||
There was a problem hiding this comment.
Add porting notes that noncomputable was required.
Mathlib/Control/Fix.lean
Outdated
| @@ -114,7 +115,7 @@ end Part | |||
|
|
|||
| namespace Part | |||
|
|
|||
| instance : HasFix (Part α) := | |||
| noncomputable instance : HasFix (Part α) := | |||
There was a problem hiding this comment.
porting notes on noncomputable
Mathlib/Control/Fix.lean
Outdated
| @@ -123,9 +124,8 @@ open Sigma | |||
|
|
|||
| namespace Pi | |||
|
|
|||
| instance Part.hasFix {β} : HasFix (α → Part β) := | |||
| noncomputable instance Part.hasFix {β} : HasFix (α → Part β) := | |||
There was a problem hiding this comment.
porting notes on noncomputable
jcommelin
added
awaiting-author
Shreyas4991
added
awaiting-review
|
Is there anything further to be done on this PR from my end? |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 24, 2022
Mathlib Commit : 207cfac9fcd06138865b5d04f7091e46d9320432 Co-authored-by: Arien Malec <arien.malec@gmail.com> Co-authored-by: Reid Barton <rwbarton@gmail.com>
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mathlib Commit : 207cfac9fcd06138865b5d04f7091e46d9320432