[Merged by Bors] - doc(Algebra,AlgebraicGeometry): remove mathlib3 names in doc comments #11955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly automatic, with a few manual corrections.
grunweg
added
documentation
grunweg
commented
Apr 6, 2024
| @@ -298,7 +298,7 @@ instance instLinearOrderedCommMonoidWithZeroMultiplicativeOrderDual | |||
| { Multiplicative.orderedCommMonoid, Multiplicative.linearOrder with | |||
| zero := Multiplicative.ofAdd (⊤ : α) | |||
| zero_mul := @top_add _ (_) | |||
| -- Porting note: Here and elsewhere in the file, just `zero_mul` worked in Lean 3. See | |||
| -- Porting note: Here and elsewhere in the file, just `MulZeroClass.zero_mul` worked in Lean 3. See | |||
There was a problem hiding this comment.
Should this one be reverted?
grunweg
force-pushed
the
MR-algebraX-mathlib3-docs
branch
from
2684e34
to
205d775
Compare
Ruben-VandeVelde
requested changes
Apr 7, 2024
Ruben-VandeVelde
added
awaiting-author
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Thanks for the careful review. I have addressed all comments. |
grunweg
added
awaiting-review
Ruben-VandeVelde
approved these changes
Apr 7, 2024
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
|
bors merge |
github-actions
bot
added
ready-to-merge
|
bors r- |
|
bors d+ |
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2024
…#11955) Mostly automatic, with a few manual corrections.
|
Canceled. |
|
Please merge after CI is complete. Thanks! |
|
Thanks for the review. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2024
…#11955) Mostly automatic, with a few manual corrections.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
…#11955) Mostly automatic, with a few manual corrections.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
…#11955) Mostly automatic, with a few manual corrections.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
…#11955) Mostly automatic, with a few manual corrections.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
…#11955) Mostly automatic, with a few manual corrections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly automatic, with a few manual corrections.