Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add evalPowZeroInt positivity extension #1196

Closed
wants to merge 1 commit into from

Conversation

dwrensha
Copy link
Member

Adds a new positivity extension to handle integer exponents of value 0.
Corresponds to this piece of logic in mathlib3.

This lets us uncomment another test case.

@dwrensha dwrensha added the awaiting-review The author would like community review of the PR label Dec 24, 2022
@hrmacbeth hrmacbeth added the t-meta Tactics, attributes or user commands label Jan 2, 2023
@gebner
Copy link
Member

gebner commented Jan 5, 2023

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 5, 2023
bors bot pushed a commit that referenced this pull request Jan 5, 2023
Adds a new positivity extension to handle integer exponents of value 0.
Corresponds to [this piece of logic](https://github.com/leanprover-community/mathlib/blob/09258fb7f75d741b7eda9fa18d5c869e2135d9f1/src/tactic/positivity.lean#L582-L584) in mathlib3.

This lets us uncomment another test case.
@bors
Copy link

bors bot commented Jan 5, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: add evalPowZeroInt positivity extension [Merged by Bors] - feat: add evalPowZeroInt positivity extension Jan 5, 2023
@bors bors bot closed this Jan 5, 2023
@bors bors bot deleted the positivity-pow-zero-int branch January 5, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants