Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: coalgebra isomorphisms #11970

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: coalgebra isomorphisms #11970

wants to merge 8 commits into from

Conversation

101damnations
Copy link
Collaborator

@101damnations 101damnations commented Apr 7, 2024 •
edited
Loading

@101damnations 101damnations mentioned this pull request Apr 7, 2024
Closed
4 tasks
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib label Apr 7, 2024
This was referenced Apr 7, 2024
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib label Apr 16, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 16, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 16, 2024
@101damnations 101damnations added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Apr 17, 2024
eric-wieser
eric-wieser approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

It pains me to see us writing so much boilerplate for every algebraic morphism, but until automation appears I think we have to keep going.

Just some minor comments.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 1, 2024

✌️ 101damnations can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the awaiting-review The author would like community review of the PR label May 1, 2024
@101damnations
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request May 2, 2024
feat: coalgebra isomorphisms (#11970)
4382820 
Isomorphisms of coalgebras. Mimics `Mathlib.Algebra.Module.Equiv`.
mathlib-bors bot pushed a commit that referenced this pull request May 2, 2024
feat: coalgebra isomorphisms (#11970)
22b9916 
Isomorphisms of coalgebras. Mimics `Mathlib.Algebra.Module.Equiv`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: coalgebra isomorphisms [Merged by Bors] - feat: coalgebra isomorphisms May 2, 2024
@mathlib-bors mathlib-bors bot closed this May 2, 2024
@mathlib-bors mathlib-bors bot deleted the coalgequivs branch May 2, 2024 15:03
apnelson1 pushed a commit that referenced this pull request May 12, 2024
@apnelson1
feat: coalgebra isomorphisms (#11970)
0cbd618 
Isomorphisms of coalgebras. Mimics `Mathlib.Algebra.Module.Equiv`.
callesonne pushed a commit that referenced this pull request May 16, 2024
@callesonne
feat: coalgebra isomorphisms (#11970)
1757def 
Isomorphisms of coalgebras. Mimics `Mathlib.Algebra.Module.Equiv`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@101damnations @leanprover-community-mathlib4-bot @eric-wieser