[Merged by Bors] - feat: blacklist compiler definitions in shake #11981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Ruben-VandeVelde
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2024
As [reported on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Point.26Click.20library.20rewrite.20tactic/near/431717134). Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
As [reported on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Point.26Click.20library.20rewrite.20tactic/near/431717134). Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
As [reported on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Point.26Click.20library.20rewrite.20tactic/near/431717134). Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
* [x] Depends on: #11981 This adds a `--explain` flag to `shake` which will say, for each module in which it reports unnecessary imports, why all of the imports it is suggesting (as well as all the imports it does not recommend to remove) are required, in the form: ``` $ lake exe shake --explain ... ./././Mathlib/Tactic/Eqns.lean: remove #[Std.CodeAction.Attr, Std.Tactic.Lint.Basic] add #[Lean.Elab.InfoTree.Main, Lean.Elab.Exception] note: Mathlib.Tactic.Eqns requires Lean.Meta.Eqns because initFn✝ refers to Lean.Meta.EqnsExtState.map note: Mathlib.Tactic.Eqns requires Std.Lean.NameMapAttribute because eqnsAttribute refers to Lean.NameMapExtension note: Mathlib.Tactic.Eqns requires Lean.Elab.InfoTree.Main because initFn✝ refers to Lean.Elab.resolveGlobalConstNoOverloadWithInfo note: Mathlib.Tactic.Eqns requires Lean.Elab.Exception because initFn✝ refers to Lean.Elab.throwUnsupportedSyntax ``` Co-authored-by: Mario Carneiro <di.gama@gmail.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
As [reported on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Point.26Click.20library.20rewrite.20tactic/near/431717134). Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
* [x] Depends on: #11981 This adds a `--explain` flag to `shake` which will say, for each module in which it reports unnecessary imports, why all of the imports it is suggesting (as well as all the imports it does not recommend to remove) are required, in the form: ``` $ lake exe shake --explain ... ./././Mathlib/Tactic/Eqns.lean: remove #[Std.CodeAction.Attr, Std.Tactic.Lint.Basic] add #[Lean.Elab.InfoTree.Main, Lean.Elab.Exception] note: Mathlib.Tactic.Eqns requires Lean.Meta.Eqns because initFn✝ refers to Lean.Meta.EqnsExtState.map note: Mathlib.Tactic.Eqns requires Std.Lean.NameMapAttribute because eqnsAttribute refers to Lean.NameMapExtension note: Mathlib.Tactic.Eqns requires Lean.Elab.InfoTree.Main because initFn✝ refers to Lean.Elab.resolveGlobalConstNoOverloadWithInfo note: Mathlib.Tactic.Eqns requires Lean.Elab.Exception because initFn✝ refers to Lean.Elab.throwUnsupportedSyntax ``` Co-authored-by: Mario Carneiro <di.gama@gmail.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
As [reported on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Point.26Click.20library.20rewrite.20tactic/near/431717134). Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
* [x] Depends on: #11981 This adds a `--explain` flag to `shake` which will say, for each module in which it reports unnecessary imports, why all of the imports it is suggesting (as well as all the imports it does not recommend to remove) are required, in the form: ``` $ lake exe shake --explain ... ./././Mathlib/Tactic/Eqns.lean: remove #[Std.CodeAction.Attr, Std.Tactic.Lint.Basic] add #[Lean.Elab.InfoTree.Main, Lean.Elab.Exception] note: Mathlib.Tactic.Eqns requires Lean.Meta.Eqns because initFn✝ refers to Lean.Meta.EqnsExtState.map note: Mathlib.Tactic.Eqns requires Std.Lean.NameMapAttribute because eqnsAttribute refers to Lean.NameMapExtension note: Mathlib.Tactic.Eqns requires Lean.Elab.InfoTree.Main because initFn✝ refers to Lean.Elab.resolveGlobalConstNoOverloadWithInfo note: Mathlib.Tactic.Eqns requires Lean.Elab.Exception because initFn✝ refers to Lean.Elab.throwUnsupportedSyntax ``` Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
* [x] Depends on: #11981 This adds a `--explain` flag to `shake` which will say, for each module in which it reports unnecessary imports, why all of the imports it is suggesting (as well as all the imports it does not recommend to remove) are required, in the form: ``` $ lake exe shake --explain ... ./././Mathlib/Tactic/Eqns.lean: remove #[Std.CodeAction.Attr, Std.Tactic.Lint.Basic] add #[Lean.Elab.InfoTree.Main, Lean.Elab.Exception] note: Mathlib.Tactic.Eqns requires Lean.Meta.Eqns because initFn✝ refers to Lean.Meta.EqnsExtState.map note: Mathlib.Tactic.Eqns requires Std.Lean.NameMapAttribute because eqnsAttribute refers to Lean.NameMapExtension note: Mathlib.Tactic.Eqns requires Lean.Elab.InfoTree.Main because initFn✝ refers to Lean.Elab.resolveGlobalConstNoOverloadWithInfo note: Mathlib.Tactic.Eqns requires Lean.Elab.Exception because initFn✝ refers to Lean.Elab.throwUnsupportedSyntax ``` Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on Zulip.