[Merged by Bors] - chore: make two proofs robust #11983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2024
Proofs by `simp` with many `-lemmas` are very fragile, and indeed this one broke on `nightly-testing`. Replaces with clearer proofs that use the relevant results already established, rather than fighting with `simp`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
Proofs by `simp` with many `-lemmas` are very fragile, and indeed this one broke on `nightly-testing`. Replaces with clearer proofs that use the relevant results already established, rather than fighting with `simp`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Proofs by `simp` with many `-lemmas` are very fragile, and indeed this one broke on `nightly-testing`. Replaces with clearer proofs that use the relevant results already established, rather than fighting with `simp`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Proofs by `simp` with many `-lemmas` are very fragile, and indeed this one broke on `nightly-testing`. Replaces with clearer proofs that use the relevant results already established, rather than fighting with `simp`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Proofs by `simp` with many `-lemmas` are very fragile, and indeed this one broke on `nightly-testing`. Replaces with clearer proofs that use the relevant results already established, rather than fighting with `simp`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proofs by
simpwith many-lemmasare very fragile, and indeed this one broke onnightly-testing.Replaces with clearer proofs that use the relevant results already established, rather than fighting with
simp.