New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - doc: fix many more mathlib3 names in doc comments #11987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- doc(Topology): remove confusing comment - replace `pointwise`, `variables`, `periodic` by their proper version Pointwise, variable and Periodic, respectively.
- doc(Topology): fix misleading comment pairwise_intersections is not a declaration name, hence make quotes instead - doc(Topology): fix two old declaration names in comments - I presume complete_structure -> CompleteLattice; not 100% sure. - fix old file name: just remove this instead?
And correct one mis-port as I noted it.
grunweg
added
documentation
Improvements or additions to documentation
awaiting-review
The author would like community review of the PR
labels
Apr 7, 2024
j-loreaux
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
bors d+
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
The author would like community review of the PR
labels
Apr 8, 2024
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Thanks for the quick and careful review. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
A mix of various changes; generated with a script and manually tweaked.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
doc: fix many more mathlib3 names in doc comments
[Merged by Bors] - doc: fix many more mathlib3 names in doc comments
Apr 8, 2024
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
A mix of various changes; generated with a script and manually tweaked.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
A mix of various changes; generated with a script and manually tweaked.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
A mix of various changes; generated with a script and manually tweaked.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
A mix of various changes; generated with a script and manually tweaked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mix of various changes; generated with a script and manually tweaked.
Commits can be reviewed individually; sometimes, they're grouped by theme, sometimes by directory.