Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - doc: fix many more mathlib3 names in doc comments #11987

Closed
wants to merge 9 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Apr 7, 2024

A mix of various changes; generated with a script and manually tweaked.


Commits can be reviewed individually; sometimes, they're grouped by theme, sometimes by directory.


Open in Gitpod

- doc(Topology): remove confusing comment
- replace `pointwise`, `variables`, `periodic` by their proper version
Pointwise, variable and Periodic, respectively.
- doc(Topology): fix misleading comment
pairwise_intersections is not a declaration name, hence make quotes instead
- doc(Topology): fix two old declaration names in comments
- I presume complete_structure -> CompleteLattice; not 100% sure.
- fix old file name: just remove this instead?
And correct one mis-port as I noted it.
@grunweg grunweg added documentation Improvements or additions to documentation awaiting-review The author would like community review of the PR labels Apr 7, 2024
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

bors d+

Mathlib/MeasureTheory/Integral/Layercake.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Order/IntermediateValue.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Order/IntermediateValue.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 8, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Apr 8, 2024
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@grunweg
Copy link
Collaborator Author

grunweg commented Apr 8, 2024

Thanks for the quick and careful review.
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 8, 2024
A mix of various changes; generated with a script and manually tweaked.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 8, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc: fix many more mathlib3 names in doc comments [Merged by Bors] - doc: fix many more mathlib3 names in doc comments Apr 8, 2024
@mathlib-bors mathlib-bors bot closed this Apr 8, 2024
@mathlib-bors mathlib-bors bot deleted the MR-various-mathlib3-names branch April 8, 2024 07:22
Louddy pushed a commit that referenced this pull request Apr 15, 2024
A mix of various changes; generated with a script and manually tweaked.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
A mix of various changes; generated with a script and manually tweaked.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
A mix of various changes; generated with a script and manually tweaked.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
A mix of various changes; generated with a script and manually tweaked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants