Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.Cover #1200

Closed
wants to merge 19 commits into from
Closed

[Merged by Bors] - feat: port Order.Cover #1200

wants to merge 19 commits into from

Conversation

riccardobrasca
Copy link
Member

@riccardobrasca riccardobrasca commented Dec 24, 2022 •
edited by bors bot

No description provided.

@riccardobrasca riccardobrasca added mathlib-port This is a port of a theory file from mathlib. WIP Work in progress labels Dec 24, 2022
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Dec 24, 2022
@rwbarton rwbarton changed the title Port/Order.Cover feat: port Order.Cover Dec 24, 2022
dupuisf
dupuisf reviewed Dec 25, 2022
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few name changes, otherwise looks good!

bors d+

Mathlib/Order/Cover.lean Outdated Show resolved Hide resolved
Mathlib/Order/Cover.lean Outdated Show resolved Hide resolved
Mathlib/Order/Cover.lean Outdated Show resolved Hide resolved
Mathlib/Order/Cover.lean Outdated Show resolved Hide resolved
Mathlib/Order/Cover.lean Outdated Show resolved Hide resolved
Mathlib/Order/Cover.lean Outdated Show resolved Hide resolved
Mathlib/Order/Cover.lean Outdated Show resolved Hide resolved
Mathlib/Order/Cover.lean Outdated Show resolved Hide resolved
Mathlib/Order/Cover.lean Outdated Show resolved Hide resolved
Mathlib/Order/Cover.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Dec 25, 2022

✌️ riccardobrasca can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed awaiting-review The author would like community review of the PR labels Dec 25, 2022
riccardobrasca and others added 11 commits December 26, 2022 20:46
@riccardobrasca @dupuisf
Update Mathlib/Order/Cover.lean
42bd647 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@riccardobrasca @dupuisf
Update Mathlib/Order/Cover.lean
90ad0b6 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@riccardobrasca @dupuisf
Update Mathlib/Order/Cover.lean
ec36bad 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@riccardobrasca @dupuisf
Update Mathlib/Order/Cover.lean
c0a1842 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@riccardobrasca @dupuisf
Update Mathlib/Order/Cover.lean
300d33c 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@riccardobrasca @dupuisf
Update Mathlib/Order/Cover.lean
27f9e50 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@riccardobrasca @dupuisf
Update Mathlib/Order/Cover.lean
8bf5f83 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@riccardobrasca @dupuisf
Update Mathlib/Order/Cover.lean
14e901f 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@riccardobrasca @dupuisf
Update Mathlib/Order/Cover.lean
1db5c76 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@riccardobrasca @dupuisf
Update Mathlib/Order/Cover.lean
1e9eafb 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@riccardobrasca
Merge remote-tracking branch 'origin/master' into port/Order.Cover
89d2e1f
@riccardobrasca riccardobrasca removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 26, 2022
@riccardobrasca
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Dec 26, 2022
bors bot pushed a commit that referenced this pull request Dec 26, 2022
@riccardobrasca
feat: port Order.Cover (#1200)
26b1d76
@bors
Copy link

bors bot commented Dec 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.Cover [Merged by Bors] - feat: port Order.Cover Dec 26, 2022
@bors bors bot closed this Dec 26, 2022
@bors bors bot deleted the port/Order.Cover branch December 26, 2022 20:45
@github-actions github-actions bot mentioned this pull request Dec 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@riccardobrasca @dupuisf @semorrison