Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Data/DFinsupp/Basic): remove impossible →ₚ notation #12018

Closed
wants to merge 1 commit into from

Conversation

negiizhao
Copy link
Collaborator

@negiizhao negiizhao commented Apr 8, 2024

This is a binary operator that expands to a unary function; so this notation is (and has always been) impossible to use.


Open in Gitpod

@negiizhao negiizhao added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Apr 8, 2024
@grunweg
Copy link
Collaborator

grunweg commented Apr 14, 2024

To me, as a non-expert in this area, it's hard to judge whether this change is a good idea - as there's context missing.
Can you elaborate more why this notation makes no sense? (Or try to reconstruct when/why it was added in the first place?) Perhaps an expert in this area of mathlib will find this obvious, but I don't :-)

@negiizhao
Copy link
Collaborator Author

Just look at the type of DFinsupp : ∀ {ι : Type*} (β : ι → Type*) [(i : ι) → Zero (β i)], Type _. It's not a binary operation.

@eric-wieser eric-wieser changed the title chore(Data/DFinsupp/Basic): remove notation that makes no sense chore(Data/DFinsupp/Basic): remove impossible →ₚ notation Apr 16, 2024
@eric-wieser
Copy link
Member

bors merge

Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 16, 2024
This is a binary operator that expands to a unary function; so this notation is (and has always been) impossible to use.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 16, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Apr 16, 2024
This is a binary operator that expands to a unary function; so this notation is (and has always been) impossible to use.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 17, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/DFinsupp/Basic): remove impossible →ₚ notation [Merged by Bors] - chore(Data/DFinsupp/Basic): remove impossible →ₚ notation Apr 17, 2024
@mathlib-bors mathlib-bors bot closed this Apr 17, 2024
@mathlib-bors mathlib-bors bot deleted the FR_remove_dfinsupp_notation branch April 17, 2024 00:28
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
This is a binary operator that expands to a unary function; so this notation is (and has always been) impossible to use.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
This is a binary operator that expands to a unary function; so this notation is (and has always been) impossible to use.
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
This is a binary operator that expands to a unary function; so this notation is (and has always been) impossible to use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants