Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: remove some porting notes in sphere #12059

Closed
wants to merge 2 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Apr 11, 2024

Found after examining the bug fixes in #12054, although these improvements are unrelated to the test PR.


Open in Gitpod

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@adomani adomani added awaiting-review The author would like community review of the PR porting-notes Mathlib3 to Mathlib4 porting notes. labels Apr 11, 2024
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement to me. Thanks for doing this!
(I'm low-to-medium confident on this one.)

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@mattrobball
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 11, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 11, 2024
Found after examining the bug fixes in #12054, although these improvements are unrelated to the test PR.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove some porting notes in sphere [Merged by Bors] - chore: remove some porting notes in sphere Apr 11, 2024
@mathlib-bors mathlib-bors bot closed this Apr 11, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/restore_sphere_proof branch April 11, 2024 15:29
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Found after examining the bug fixes in #12054, although these improvements are unrelated to the test PR.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
Found after examining the bug fixes in #12054, although these improvements are unrelated to the test PR.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Found after examining the bug fixes in #12054, although these improvements are unrelated to the test PR.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Found after examining the bug fixes in #12054, although these improvements are unrelated to the test PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants