[Merged by Bors] - chore: rename StarOrderedRing convenience constructors
#12089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-loreaux
added
awaiting-review
eric-wieser
approved these changes
Apr 13, 2024
|
✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
`StarOrderedRing` was recently turned into a `Prop` mixin. This renames the convenience constructors to adhere to the naming convention for theorems vs. defs.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
StarOrderedRing convenience constructorsStarOrderedRing convenience constructors
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
`StarOrderedRing` was recently turned into a `Prop` mixin. This renames the convenience constructors to adhere to the naming convention for theorems vs. defs.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
`StarOrderedRing` was recently turned into a `Prop` mixin. This renames the convenience constructors to adhere to the naming convention for theorems vs. defs.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
`StarOrderedRing` was recently turned into a `Prop` mixin. This renames the convenience constructors to adhere to the naming convention for theorems vs. defs.
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
`StarOrderedRing` was recently turned into a `Prop` mixin. This renames the convenience constructors to adhere to the naming convention for theorems vs. defs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StarOrderedRingwas recently turned into aPropmixin. This renames the convenience constructors to adhere to the naming convention for theorems vs. defs.