Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(RingTheory/IsTensorProduct): resolve porting note about simps! #12092

Closed
wants to merge 1 commit into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Apr 12, 2024

Uncomment the simps configuration (which has to become simps!) and delete the generated lemma which was added manually. I verified that both are identical.


Inspired by #12088; this is the only other porting note referencing lemmasOnly.


Open in Gitpod

Uncomment the simps configuration (which has to become simps!)
and delete the generated lemma which was added manually.
Both are identical (I checked).
@grunweg grunweg added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Apr 12, 2024
@erdOne
Copy link
Member

erdOne commented Apr 12, 2024

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

@grunweg grunweg added the porting-notes Mathlib3 to Mathlib4 porting notes. label Apr 12, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 13, 2024
…12092)

Uncomment the simps configuration (which has to become simps!) and delete the generated lemma which was added manually. I verified that both are identical.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(RingTheory/IsTensorProduct): resolve porting note about simps! [Merged by Bors] - chore(RingTheory/IsTensorProduct): resolve porting note about simps! Apr 13, 2024
@mathlib-bors mathlib-bors bot closed this Apr 13, 2024
@mathlib-bors mathlib-bors bot deleted the MR-porting-notes-lemmasonly branch April 13, 2024 04:55
Louddy pushed a commit that referenced this pull request Apr 15, 2024
…12092)

Uncomment the simps configuration (which has to become simps!) and delete the generated lemma which was added manually. I verified that both are identical.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
…12092)

Uncomment the simps configuration (which has to become simps!) and delete the generated lemma which was added manually. I verified that both are identical.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
…12092)

Uncomment the simps configuration (which has to become simps!) and delete the generated lemma which was added manually. I verified that both are identical.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
…12092)

Uncomment the simps configuration (which has to become simps!) and delete the generated lemma which was added manually. I verified that both are identical.
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
…12092)

Uncomment the simps configuration (which has to become simps!) and delete the generated lemma which was added manually. I verified that both are identical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants