-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Data/Set/Intervals/OrdConnectedComponent): resolve porting note about lift not being … #12102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implemented By now, it has been implemented; use it.
grunweg
added
awaiting-review
The author would like community review of the PR
porting-notes
Mathlib3 to Mathlib4 porting notes.
labels
Apr 12, 2024
grunweg
changed the title
chore(Data/Set/Intervals): resolve porting note about lift not being …
chore(Data/Set/Intervals/OrdConnectedComponent): resolve porting note about lift not being …
Apr 12, 2024
grunweg
added
the
easy
< 20s of review time. See the lifecycle page for guidelines.
label
Apr 12, 2024
jcommelin
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
leanprover-community-mathlib4-bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Apr 13, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 13, 2024
… about lift not being … (#12102) …implemented By now, it has been implemented; use it.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore(Data/Set/Intervals/OrdConnectedComponent): resolve porting note about lift not being …
[Merged by Bors] - chore(Data/Set/Intervals/OrdConnectedComponent): resolve porting note about lift not being …
Apr 13, 2024
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
… about lift not being … (#12102) …implemented By now, it has been implemented; use it.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
… about lift not being … (#12102) …implemented By now, it has been implemented; use it.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
… about lift not being … (#12102) …implemented By now, it has been implemented; use it.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
… about lift not being … (#12102) …implemented By now, it has been implemented; use it.
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
… about lift not being … (#12102) …implemented By now, it has been implemented; use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
easy
< 20s of review time. See the lifecycle page for guidelines.
porting-notes
Mathlib3 to Mathlib4 porting notes.
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…implemented
By now, it has been implemented; use it.
Suggestions for further proof tweaks are welcome.