New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: reduce proof dependencies for Nat.factors_count_eq #12105
Conversation
This is a bit longer, partially duplicating the argument from UniqueFactorizationMonoid.multiplicity_eq_count_normalizedFactors, but it means we no longer need to depend on UFDs at this point. The other added lemmas seem useful regardless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't understand why depending on UFDs for nat factorization is a bad thing; why make the generalization if we're then going to re-derive the results without it anyway? Are UFDs an overly-heavy import? Can we reduce that dependency tree instead? |
Not sure why I wrote UFDs there - it's more than just the definition, but the instance for Nat is in For UFDs in particular, we can lighten a bit by moving |
bors merge |
This is a bit longer, partially duplicating the argument from UniqueFactorizationMonoid.multiplicity_eq_count_normalizedFactors, but it means we no longer need to depend on `RingTheory.Int.Basic` at this point. The other added lemmas seem useful regardless.
Pull request successfully merged into master. Build succeeded: |
This is a bit longer, partially duplicating the argument from UniqueFactorizationMonoid.multiplicity_eq_count_normalizedFactors, but it means we no longer need to depend on `RingTheory.Int.Basic` at this point. The other added lemmas seem useful regardless.
This is a bit longer, partially duplicating the argument from UniqueFactorizationMonoid.multiplicity_eq_count_normalizedFactors, but it means we no longer need to depend on `RingTheory.Int.Basic` at this point. The other added lemmas seem useful regardless.
This is a bit longer, partially duplicating the argument from UniqueFactorizationMonoid.multiplicity_eq_count_normalizedFactors, but it means we no longer need to depend on
RingTheory.Int.Basic
at this point.The other added lemmas seem useful regardless.