Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: restore simps that used to work #12126

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: restore simps that used to work #12126

wants to merge 2 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Apr 14, 2024

Open in Gitpod

@mo271
Copy link
Collaborator Author

mo271 commented Apr 14, 2024

!bench

@mo271
Copy link
Collaborator Author

mo271 commented Apr 14, 2024

I added !bench although I don't really expect any regression in speed, but just to be sure...

@mo271 mo271 added awaiting-review The author would like community review of the PR awaiting-CI labels Apr 14, 2024
@grunweg
Copy link
Collaborator

grunweg commented Apr 14, 2024

There's some overlap with #12128 (but not too bad). In any case, thanks for doing this also!

grunweg
grunweg approved these changes Apr 14, 2024
View reviewed changes
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, looks good to me!

Mathlib/Analysis/NormedSpace/AffineIsometry.lean Show resolved Hide resolved
Mathlib/Analysis/NormedSpace/AffineIsometry.lean Show resolved Hide resolved
@grunweg grunweg added the porting-notes Mathlib3 to Mathlib4 porting notes. label Apr 14, 2024
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit c86dcd2.
There were no significant changes against commit f822da5.

@mo271
Copy link
Collaborator Author

mo271 commented Apr 14, 2024

There's some overlap with #12128 (but not too bad). In any case, thanks for doing this also!

Haha, that was almost at the same moment...
Happy to do rebasing in either order..

@grunweg
Copy link
Collaborator

grunweg commented Apr 14, 2024

If you want to continue along this vein, this branch of mine contains a few more changes that I haven't cleaned up yet (and my three porting notes PRs of this morning). I will eventually get to these. But if you want (no pressure!!), feel welcome to crib/clean those up.

@mo271
Copy link
Collaborator Author

mo271 commented Apr 14, 2024

If you want to continue along this vein, this branch of mine contains a few more changes that I haven't cleaned up yet (and my three porting notes PRs of this morning). I will eventually get to these. But if you want (no pressure!!), feel welcome to crib/clean those up.

I have no commits in the vein planned, so please go ahead without me

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 15, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 15, 2024
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 15, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 15, 2024
@mo271
chore: restore simps that used to work (#12126)
7c5b29b 
Co-authored-by: Moritz Firsching <firsching@google.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 15, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: restore simps that used to work [Merged by Bors] - chore: restore simps that used to work Apr 15, 2024
@mathlib-bors mathlib-bors bot closed this Apr 15, 2024
@mathlib-bors mathlib-bors bot deleted the mo271/simp_porting_notes branch April 15, 2024 06:45
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@mo271 @Louddy
chore: restore simps that used to work (#12126)
e7dd2dc 
Co-authored-by: Moritz Firsching <firsching@google.com>
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
@mo271 @atarnoam
chore: restore simps that used to work (#12126)
9bb08c6 
Co-authored-by: Moritz Firsching <firsching@google.com>
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
@mo271 @uniwuni
chore: restore simps that used to work (#12126)
b9f8c43 
Co-authored-by: Moritz Firsching <firsching@google.com>
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@mo271 @callesonne
chore: restore simps that used to work (#12126)
ea51853 
Co-authored-by: Moritz Firsching <firsching@google.com>
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
@mo271 @Jun2M
chore: restore simps that used to work (#12126)
8232326 
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grunweg grunweg grunweg approved these changes

Assignees
No one assigned
Labels
porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mo271 @grunweg @leanprover-bot @semorrison @leanprover-community-mathlib4-bot