Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(LinearAlgebra/BilinearForm/Basic): Deprecate coercions #12132

Closed
wants to merge 2 commits into from

Conversation

mans0954
Copy link
Collaborator

Following #11278 the coercions in LinearAlgebra/BilinearForm/Basic are no longer useful. This PR deprecates them.


Open in Gitpod

@mans0954 mans0954 added the awaiting-review The author would like community review of the PR label Apr 14, 2024
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

I think two of these should remain undeprecated, but the rest look good.

@mathlib-bors
Copy link

mathlib-bors bot commented Apr 14, 2024

✌️ mans0954 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Apr 14, 2024
@mans0954
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 14, 2024
Following #11278 the coercions in `LinearAlgebra/BilinearForm/Basic` are no longer useful. This PR deprecates them.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(LinearAlgebra/BilinearForm/Basic): Deprecate coercions [Merged by Bors] - refactor(LinearAlgebra/BilinearForm/Basic): Deprecate coercions Apr 14, 2024
@mathlib-bors mathlib-bors bot closed this Apr 14, 2024
@mathlib-bors mathlib-bors bot deleted the mans0954/BilinearForm-Basic-deprecate-coe branch April 14, 2024 14:43
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Following #11278 the coercions in `LinearAlgebra/BilinearForm/Basic` are no longer useful. This PR deprecates them.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
Following #11278 the coercions in `LinearAlgebra/BilinearForm/Basic` are no longer useful. This PR deprecates them.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
Following #11278 the coercions in `LinearAlgebra/BilinearForm/Basic` are no longer useful. This PR deprecates them.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Following #11278 the coercions in `LinearAlgebra/BilinearForm/Basic` are no longer useful. This PR deprecates them.
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
Following #11278 the coercions in `LinearAlgebra/BilinearForm/Basic` are no longer useful. This PR deprecates them.
mathlib-bors bot pushed a commit that referenced this pull request May 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 5, 2024
apnelson1 pushed a commit that referenced this pull request May 12, 2024
callesonne pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants