[Merged by Bors] - chore(Topology): make LocallyConstant.comap computable
#12182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagurtomas
added
awaiting-review
4 tasks
eric-wieser
reviewed
Apr 16, 2024
eric-wieser
reviewed
Apr 16, 2024
|
bors merge Thanks! |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
After the recent refactor (#12136), the `noncomputable` modifier is unnecessary, and the docstring needed modification.
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
After the recent refactor (#12136), the `noncomputable` modifier is unnecessary, and the docstring needed modification.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
LocallyConstant.comap computableLocallyConstant.comap computable
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
After the recent refactor (#12136), the `noncomputable` modifier is unnecessary, and the docstring needed modification.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
After the recent refactor (#12136), the `noncomputable` modifier is unnecessary, and the docstring needed modification.
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
After the recent refactor (#12136), the `noncomputable` modifier is unnecessary, and the docstring needed modification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the recent refactor (#12136), the
noncomputablemodifier is unnecessary, and the docstring needed modification.