-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port data.set.intervals.pi #1223
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hargoniX
added
awaiting-review
The author would like community review of the PR
mathlib-port
This is a port of a theory file from mathlib.
labels
Dec 26, 2022
You don't need to change bors merge |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Dec 26, 2022
ChrisHughes24
changed the title
feat Port/data.set.intervals.pi
feat: port data.set.intervals.pi
Dec 26, 2022
bors bot
pushed a commit
that referenced
this pull request
Dec 26, 2022
I changed a single proof, `Icc_diff_pi_univ_Ioo_subset` because the `simpa` got lost somewhere along the way. It did produce an existential statement in the end but it was not the correct one it seems. Since the proof was easy enough to fix without `simpa` I just did that instead of figuring out what exactly is going wrong.
hargoniX
force-pushed
the
port/Data.Set.Intervals.Pi
branch
from
December 26, 2022 16:42
e46ff12
to
3260271
Compare
Canceled. |
I force pushed to make the simp proof a little better, you'll have to merge again /o\ |
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 26, 2022
I changed a single proof, `Icc_diff_pi_univ_Ioo_subset` because the `simpa` got lost somewhere along the way. It did produce an existential statement in the end but it was not the correct one it seems. Since the proof was easy enough to fix without `simpa` I just did that instead of figuring out what exactly is going wrong.
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
feat: port data.set.intervals.pi
[Merged by Bors] - feat: port data.set.intervals.pi
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mathlib-port
This is a port of a theory file from mathlib.
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed a single proof,
Icc_diff_pi_univ_Ioo_subset
because thesimpa
got lost somewhere along the way. It did produce an existential statement in the end but it was not the correct one it seems. Since the proof was easy enough to fix withoutsimpa
I just did that instead of figuring out what exactly is going wrong.