Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port data.set.intervals.pi #1223

Closed
wants to merge 3 commits into from

Conversation

hargoniX
Copy link
Collaborator

@hargoniX hargoniX commented Dec 26, 2022

I changed a single proof, Icc_diff_pi_univ_Ioo_subset because the simpa got lost somewhere along the way. It did produce an existential statement in the end but it was not the correct one it seems. Since the proof was easy enough to fix without simpa I just did that instead of figuring out what exactly is going wrong.

@hargoniX hargoniX added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Dec 26, 2022
@hargoniX hargoniX self-assigned this Dec 26, 2022
@hargoniX hargoniX marked this pull request as ready for review December 26, 2022 16:30
@ChrisHughes24
Copy link
Member

You don't need to change => to by the way. Most people don't, but I don't think it matters either way.

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 26, 2022
@ChrisHughes24 ChrisHughes24 changed the title feat Port/data.set.intervals.pi feat: port data.set.intervals.pi Dec 26, 2022
bors bot pushed a commit that referenced this pull request Dec 26, 2022
I changed a single proof, `Icc_diff_pi_univ_Ioo_subset` because the `simpa` got lost somewhere along the way. It did produce an existential statement in the end but it was not the correct one it seems. Since the proof was easy enough to fix without `simpa` I just did that instead of figuring out what exactly is going wrong.
@bors
Copy link

bors bot commented Dec 26, 2022

Canceled.

@hargoniX
Copy link
Collaborator Author

I force pushed to make the simp proof a little better, you'll have to merge again /o\

@ChrisHughes24
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Dec 26, 2022
I changed a single proof, `Icc_diff_pi_univ_Ioo_subset` because the `simpa` got lost somewhere along the way. It did produce an existential statement in the end but it was not the correct one it seems. Since the proof was easy enough to fix without `simpa` I just did that instead of figuring out what exactly is going wrong.
@bors
Copy link

bors bot commented Dec 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port data.set.intervals.pi [Merged by Bors] - feat: port data.set.intervals.pi Dec 26, 2022
@bors bors bot closed this Dec 26, 2022
@bors bors bot deleted the port/Data.Set.Intervals.Pi branch December 26, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants