[Merged by Bors] - feat(Nat/Defs): Add div_dvd_iff_dvd_mul #12243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Jun2M
commented
Apr 18, 2024
Jun2M
commented
github-actions
bot
added
the
new-contributor
Jun2M
added
awaiting-review
eric-wieser
reviewed
Apr 18, 2024
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
YaelDillies
reviewed
Apr 20, 2024
Mathlib/Data/Nat/Defs.lean
Outdated
| rw [← Nat.mul_assoc, Nat.mul_comm _ (a / b), Nat.div_mul_cancel h] | ||
| exact Nat.dvd_mul_right a e | ||
|
|
||
| @[simp] lemma div_dvd_iff_dvd_mul (h : b ∣ a) (hbpos : 0 < b) : a / b ∣ c ↔ a ∣ b * c := |
There was a problem hiding this comment.
We prefer using 0 < b instead of b ≠ 0 when b is a natural.
Suggested change
| @[simp] lemma div_dvd_iff_dvd_mul (h : b ∣ a) (hbpos : 0 < b) : a / b ∣ c ↔ a ∣ b * c := | |
| @[simp] lemma div_dvd_iff_dvd_mul (h : b ∣ a) (hb : b ≠ 0) : a / b ∣ c ↔ a ∣ b * c := |
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
leanprover-community-mathlib4-bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Jun2M
added a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.