Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - doc(Algebra/Jordan/Basic): Fix documentation for commutative real Jordan algebra #12325

Closed
wants to merge 1 commit into from

Conversation

mans0954
Copy link
Collaborator

Originally the commutativity axiom was built into IsCommJordan. This was removed in #7060 when CommMagma was introduced. However, updating the module docstring was omitted. This PR corrects the docstring to reflect the current situation.


Open in Gitpod

@mans0954 mans0954 added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Apr 21, 2024
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 22, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 22, 2024
…dan algebra (#12325)

Originally the commutativity axiom was built into `IsCommJordan`. This was removed in #7060 when `CommMagma` was introduced. However, updating the module docstring was omitted. This PR corrects the docstring to reflect the current situation.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc(Algebra/Jordan/Basic): Fix documentation for commutative real Jordan algebra [Merged by Bors] - doc(Algebra/Jordan/Basic): Fix documentation for commutative real Jordan algebra Apr 22, 2024
@mathlib-bors mathlib-bors bot closed this Apr 22, 2024
@mathlib-bors mathlib-bors bot deleted the mans0954/comm-jordan-doc-fix branch April 22, 2024 03:46
callesonne pushed a commit that referenced this pull request Apr 22, 2024
…dan algebra (#12325)

Originally the commutativity axiom was built into `IsCommJordan`. This was removed in #7060 when `CommMagma` was introduced. However, updating the module docstring was omitted. This PR corrects the docstring to reflect the current situation.
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
…dan algebra (#12325)

Originally the commutativity axiom was built into `IsCommJordan`. This was removed in #7060 when `CommMagma` was introduced. However, updating the module docstring was omitted. This PR corrects the docstring to reflect the current situation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants