[Merged by Bors] - chore: remove redundant LinearEquiv.map_neg/sub #12330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruben-VandeVelde
added
the
awaiting-review
4 tasks
loefflerd
reviewed
Apr 24, 2024
Comment on lines
+900
to
+901
| #align linear_equiv.map_neg map_negₓ | ||
| #align linear_equiv.map_sub map_subₓ |
There was a problem hiding this comment.
What's the significance of the little x here?
There was a problem hiding this comment.
The porting wiki contains this:
"when mathport suggests that you add ₓ in the name of an #align statement, figure out why it wants that and leave a porting note. Common reasons are:
- a change in the order of universe variables, typeclass arguments or implicit arguments
- some other defeq change, due to a change deep down in core or std."
See also https://github.com/leanprover-community/mathlib4/wiki/Porting-wiki#aligning-names.
There was a problem hiding this comment.
It means that the types don't match up exactly; in this case the new lemma is much more general.
loefflerd
added
awaiting-author
Ruben-VandeVelde
added
awaiting-review
|
I think this is useful to keep as sometimes |
|
I have not experienced that |
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
These are redundant with `_root_.{map_neg,map_sub}`.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
These are redundant with `_root_.{map_neg,map_sub}`.
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
These are redundant with `_root_.{map_neg,map_sub}`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are redundant with
_root_.{map_neg,map_sub}.