Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port GroupTheory.Subsemigroup.Operations #1235

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat: port GroupTheory.Subsemigroup.Operations #1235

wants to merge 13 commits into from

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Dec 27, 2022 •
edited by bors bot

No description provided.

@ChrisHughes24 ChrisHughes24 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 27, 2022
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Dec 27, 2022
@alreadydone
Copy link
Contributor

Maybe you could check if the changes here is necessary for Lean 4, and make the corresponding changes in this PR if they are?

Ruben-VandeVelde
Ruben-VandeVelde previously requested changes Dec 28, 2022
View reviewed changes
Mathlib/GroupTheory/Subsemigroup/Operations.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Subsemigroup/Operations.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Subsemigroup/Operations.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Subsemigroup/Operations.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Subsemigroup/Operations.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Subsemigroup/Operations.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Subsemigroup/Operations.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Subsemigroup/Operations.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Subsemigroup/Operations.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Subsemigroup/Operations.lean Outdated Show resolved Hide resolved
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 28, 2022
ChrisHughes24 and others added 4 commits December 29, 2022 13:26
@ChrisHughes24 @Ruben-VandeVelde
Apply suggestions from code review
7e0bfe9 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@ChrisHughes24
simp priority
92c3c58
@ChrisHughes24
make MulMemClass and AddMemClass Prop
27d48d1
@ChrisHughes24
add some #aligns
8e1d5e6
@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 29, 2022
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 29, 2022
@ChrisHughes24 ChrisHughes24 removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 29, 2022
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 31, 2022
bors bot pushed a commit that referenced this pull request Dec 31, 2022
@ChrisHughes24
feat: port GroupTheory.Subsemigroup.Operations (#1235)
1e1ba1e 
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
@bors
Copy link

bors bot commented Dec 31, 2022

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@bors bors bot changed the title feat: port GroupTheory.Subsemigroup.Operations [Merged by Bors] - feat: port GroupTheory.Subsemigroup.Operations Dec 31, 2022
@bors bors bot closed this Dec 31, 2022
@bors bors bot deleted the GroupTheory.Subsemigroup.Operations branch December 31, 2022 09:42
@github-actions github-actions bot mentioned this pull request Jan 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ChrisHughes24 @alreadydone @riccardobrasca @Ruben-VandeVelde @semorrison