Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(CategoryTheory/Adjunction): move Adjunction.restrictFullyFaithful to separate file #12363

Closed
wants to merge 23 commits into from

Conversation

dagurtomas
Copy link
Collaborator

@dagurtomas dagurtomas commented Apr 23, 2024

Also resolves a TODO to add lemmas about Adjunction.restrictFullyFaithful


Open in Gitpod

@dagurtomas dagurtomas added awaiting-review The author would like community review of the PR awaiting-CI t-category-theory Category theory labels Apr 23, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Apr 23, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@joelriou
Copy link
Collaborator

You removed two TODOs from the original file, but I do not see them after your moved the code. There was one about full/faithful separately, and the other one was about lemmas describing the produced adjunction, but I do not see where are these lemmas?!

@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 24, 2024
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@dagurtomas dagurtomas added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 25, 2024
@joelriou
Copy link
Collaborator

The equational lemmas that are automatically produced are not the greatest (because of the presence of Functor.preimage in the RHS). For unit_app, I would suggest this one instead:

@[simp, reassoc]
lemma map_restrictFullyFaithful_unit_app (X : C) :
    iC.map ((restrictFullyFaithful iC iD adj comm1 comm2).unit.app X) =
    adj.unit.app (iC.obj X) ≫ R'.map (comm1.hom.app X) ≫ comm2.hom.app (L.obj X) := by
  simp [restrictFullyFaithful]

(and something similar for counit_app).

@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 25, 2024
@dagurtomas
Copy link
Collaborator Author

Ok, thanks for the suggestion, it's done.

Do I understand correctly that adding specific lemmas for homEquiv_apply and homEquiv_symm_apply is unnecessary, becuause homEquiv_unit/homEquiv_counit together with the lemmas I added about unit/counit will simplify expressions of that form automatically?

@dagurtomas dagurtomas added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 26, 2024
@joelriou
Copy link
Collaborator

Thanks!

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Apr 26, 2024

✌️ dagurtomas can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Apr 26, 2024
dagurtomas and others added 2 commits April 26, 2024 13:52
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@dagurtomas
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 26, 2024
…ful` to separate file (#12363)

Also resolves a TODO to add lemmas about `Adjunction.restrictFullyFaithful`
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(CategoryTheory/Adjunction): move Adjunction.restrictFullyFaithful to separate file [Merged by Bors] - chore(CategoryTheory/Adjunction): move Adjunction.restrictFullyFaithful to separate file Apr 26, 2024
@mathlib-bors mathlib-bors bot closed this Apr 26, 2024
@mathlib-bors mathlib-bors bot deleted the dagur_SplitFullyFaithful branch April 26, 2024 16:16
apnelson1 pushed a commit that referenced this pull request May 12, 2024
…ful` to separate file (#12363)

Also resolves a TODO to add lemmas about `Adjunction.restrictFullyFaithful`
callesonne pushed a commit that referenced this pull request May 16, 2024
…ful` to separate file (#12363)

Also resolves a TODO to add lemmas about `Adjunction.restrictFullyFaithful`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants