New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(CategoryTheory/Adjunction): move Adjunction.restrictFullyFaithful
to separate file
#12363
Conversation
…ounit is an isomorphism
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
This PR/issue depends on: |
You removed two TODOs from the original file, but I do not see them after your moved the code. There was one about full/faithful separately, and the other one was about lemmas describing the produced adjunction, but I do not see where are these lemmas?! |
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
The equational lemmas that are automatically produced are not the greatest (because of the presence of @[simp, reassoc]
lemma map_restrictFullyFaithful_unit_app (X : C) :
iC.map ((restrictFullyFaithful iC iD adj comm1 comm2).unit.app X) =
adj.unit.app (iC.obj X) ≫ R'.map (comm1.hom.app X) ≫ comm2.hom.app (L.obj X) := by
simp [restrictFullyFaithful] (and something similar for |
Ok, thanks for the suggestion, it's done. Do I understand correctly that adding specific lemmas for |
Thanks! bors d+ |
✌️ dagurtomas can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
bors merge |
…ful` to separate file (#12363) Also resolves a TODO to add lemmas about `Adjunction.restrictFullyFaithful`
Pull request successfully merged into master. Build succeeded: |
Adjunction.restrictFullyFaithful
to separate fileAdjunction.restrictFullyFaithful
to separate file
…ful` to separate file (#12363) Also resolves a TODO to add lemmas about `Adjunction.restrictFullyFaithful`
…ful` to separate file (#12363) Also resolves a TODO to add lemmas about `Adjunction.restrictFullyFaithful`
Also resolves a TODO to add lemmas about
Adjunction.restrictFullyFaithful