Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Data/List/Perm): some nthLe -> get migration #12397

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore(Data/List/Perm): some nthLe -> get migration #12397

wants to merge 4 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Apr 24, 2024

Extracted from #12350.

Open in Gitpod

@grunweg grunweg added awaiting-review The author would like community review of the PR tech debt tracking cross-cutting technical debt labels Apr 24, 2024
@grunweg grunweg mentioned this pull request Apr 24, 2024
Closed
4 tasks
Ruben-VandeVelde
Ruben-VandeVelde approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@urkud
Copy link
Member

urkud commented May 5, 2024

Thanks! 🎉
bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 5, 2024
@grunweg @dupuisf
chore(Data/List/Perm): some nthLe -> get migration (#12397)
c1f040b 
Co-authored-by: Frédéric Dupuis <dupuisf@iro.umontreal.ca>
@mathlib-bors
Copy link

mathlib-bors bot commented May 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/List/Perm): some nthLe -> get migration [Merged by Bors] - chore(Data/List/Perm): some nthLe -> get migration May 5, 2024
@mathlib-bors mathlib-bors bot closed this May 5, 2024
@mathlib-bors mathlib-bors bot deleted the MR-list-get-perm branch May 5, 2024 05:58
@grunweg
Copy link
Collaborator Author

grunweg commented May 5, 2024

Thank you for the review!

apnelson1 pushed a commit that referenced this pull request May 12, 2024
@grunweg @dupuisf @apnelson1
chore(Data/List/Perm): some nthLe -> get migration (#12397)
8d49341 
Co-authored-by: Frédéric Dupuis <dupuisf@iro.umontreal.ca>
callesonne pushed a commit that referenced this pull request May 16, 2024
@grunweg @dupuisf @callesonne
chore(Data/List/Perm): some nthLe -> get migration (#12397)
0b51044 
Co-authored-by: Frédéric Dupuis <dupuisf@iro.umontreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees
No one assigned
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. tech debt tracking cross-cutting technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grunweg @urkud @dupuisf @Ruben-VandeVelde