Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Data/Set/List): nthLe -> get migration #12398

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore(Data/Set/List): nthLe -> get migration #12398

wants to merge 3 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Apr 24, 2024

Extracted from #12350.

Open in Gitpod

@grunweg grunweg added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. tech debt tracking cross-cutting technical debt labels Apr 24, 2024
@grunweg grunweg mentioned this pull request Apr 24, 2024
Closed
4 tasks
urkud
urkud reviewed Apr 25, 2024
View reviewed changes
Mathlib/Data/Set/List.lean Outdated Show resolved Hide resolved
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 25, 2024
@grunweg @urkud
Suggestion from code review.
3b6f01f 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@grunweg
Copy link
Collaborator Author

grunweg commented Apr 25, 2024

awaiting-review

@github-actions github-actions bot added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 25, 2024
@urkud
Copy link
Member

urkud commented Apr 27, 2024

Thanks! Once CI is happy, please merge this PR using bors r+
bors d+

P.S.: I pushed a minor golf.

@mathlib-bors
Copy link

mathlib-bors bot commented Apr 27, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Apr 27, 2024
@grunweg
Copy link
Collaborator Author

grunweg commented Apr 27, 2024

Thanks for the golf and review.
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 27, 2024
@grunweg @urkud
chore(Data/Set/List): nthLe -> get migration (#12398)
44a14fb 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Set/List): nthLe -> get migration [Merged by Bors] - chore(Data/Set/List): nthLe -> get migration Apr 27, 2024
@mathlib-bors mathlib-bors bot closed this Apr 27, 2024
@mathlib-bors mathlib-bors bot deleted the MR-list-get-set branch April 27, 2024 20:40
apnelson1 pushed a commit that referenced this pull request May 12, 2024
@grunweg @urkud @apnelson1
chore(Data/Set/List): nthLe -> get migration (#12398)
9f4ad5d 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
callesonne pushed a commit that referenced this pull request May 16, 2024
@grunweg @urkud @callesonne
chore(Data/Set/List): nthLe -> get migration (#12398)
8e2e55e 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. tech debt tracking cross-cutting technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grunweg @urkud