[Merged by Bors] - feat: port Algebra.Ring.Ulift #1240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardobrasca
added
mathlib-port
Kha
reviewed
Dec 27, 2022
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
riccardobrasca
commented
Dec 27, 2022
Mathlib/Algebra/Ring/Ulift.lean
Outdated
| intCast_negSucc := AddGroupWithOne.intCast_negSucc } | ||
| #align ulift.non_assoc_ring ULift.nonAssocRing | ||
|
|
||
| -- Porting note: this doesn't work without `refine'` |
There was a problem hiding this comment.
I don't understand why this one is different. It also looks pretty slow.
There was a problem hiding this comment.
It's to do with the definitions of Int.cast. The Int.cast field for this instance is filled in automatically as the recursive definition, but it should be inherited from the Int.cast instance on R. This should be changed and same with Nat.cast for this and the other instances.
There was a problem hiding this comment.
Adding natCast and intCast indeed fixed it, thanks!
ChrisHughes24
added
awaiting-author
riccardobrasca
added
awaiting-review
and removed
awaiting-author
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 28, 2022
Most of the porting consists of doing by hand what `pi_instance_derive_field` did. Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the porting consists of doing by hand what
pi_instance_derive_fielddid.