Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(UniformSpace) : TotallyBounded + countably generated -> Separable #12404

Closed
wants to merge 7 commits into from

Conversation

JADekker
Copy link
Collaborator

@JADekker JADekker commented Apr 24, 2024

Just a small result, that TotallyBounded sets are Separable sets in Uniform spaces with countably generated uniformities.


Open in Gitpod

@JADekker JADekker added awaiting-review The author would like community review of the PR awaiting-CI t-topology Topological spaces, uniform spaces, metric spaces, filters labels Apr 24, 2024
@JADekker JADekker added the easy < 20s of review time. See the lifecycle page for guidelines. label Apr 24, 2024
@JADekker JADekker added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR awaiting-author A reviewer has asked the author a question or requested changes labels Apr 25, 2024
@JADekker JADekker added awaiting-review The author would like community review of the PR awaiting-CI labels Apr 25, 2024
@JADekker JADekker changed the title feat(PseudoMetric) : TotallyBounded -> Separable feat(UniformSpace) : TotallyBounded + countably generated -> Separable Apr 25, 2024
@JADekker JADekker requested a review from urkud April 25, 2024 19:26
@urkud
Copy link
Member

urkud commented Apr 27, 2024

I've just noticed that EMetric.subset_countable_closure_of_almost_dense_set is a stronger version of the lemma you're proving: it assumes Countable instead of Finite, and provides a subset of s (in fact, it's used in Mathlib to prove that IsSeparable is equivalent to SeparableSpace in a metrizable topology).

@JADekker
Copy link
Collaborator Author

JADekker commented Apr 28, 2024

I've just noticed that EMetric.subset_countable_closure_of_almost_dense_set is a stronger version of the lemma you're proving: it assumes Countable instead of Finite, and provides a subset of s (in fact, it's used in Mathlib to prove that IsSeparable is equivalent to SeparableSpace in a metrizable topology).

You are right, @urkud. Are you suggesting that I close this PR, or would a refactor of my proof using this result still be valuable (as it would make sure that the necessary result turns up in moogle/loogle)? I just shortened the proof using this result, but I'm also happy to close the PR and only use this result in the original PR where I needed this (#12394).

@@ -279,3 +279,16 @@ theorem UniformSpace.metrizableSpace [UniformSpace X] [IsCountablyGenerated (
letI := UniformSpace.metricSpace X
infer_instance
#align uniform_space.metrizable_space UniformSpace.metrizableSpace

lemma TotallyBounded.isSeparable {α : Type*} [UniformSpace α] [i : IsCountablyGenerated (𝓤 α)]
{s : Set α} (h : TotallyBounded s) : TopologicalSpace.IsSeparable s:= by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reuse {X : Type*} from variables above. Also, please mention EMetric.subset_countable_closure_of_almost_dense_set in the docstring. Otherwise LGTM. Thanks!

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Apr 28, 2024

✌️ JADekker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud
Copy link
Member

urkud commented Apr 28, 2024

We have these predicates as defs, so I think that having this version of the theorem definitely makes sense.

@JADekker
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 29, 2024
#12404)

Just a small result, that TotallyBounded sets are Separable sets in Uniform spaces with countably generated uniformities.
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 29, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(UniformSpace) : TotallyBounded + countably generated -> Separable [Merged by Bors] - feat(UniformSpace) : TotallyBounded + countably generated -> Separable Apr 29, 2024
@mathlib-bors mathlib-bors bot closed this Apr 29, 2024
@mathlib-bors mathlib-bors bot deleted the JADekker_TotallyBounded_to_Separable branch April 29, 2024 09:44
@sgouezel sgouezel removed the awaiting-review The author would like community review of the PR label May 7, 2024
apnelson1 pushed a commit that referenced this pull request May 12, 2024
#12404)

Just a small result, that TotallyBounded sets are Separable sets in Uniform spaces with countably generated uniformities.
callesonne pushed a commit that referenced this pull request May 16, 2024
#12404)

Just a small result, that TotallyBounded sets are Separable sets in Uniform spaces with countably generated uniformities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants