[Merged by Bors] - refactor(Data/PNat): better OfNat instance
#12420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
Ruben-VandeVelde
approved these changes
May 5, 2024
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
|
bors r+ |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 5, 2024
Assume `[NeZero n]` instead of talking about `n+1`. This way we can reuse the raw natural literal `n` in `PNat.val_ofNat`. Also add `PNat.mk_ofNat` and drop some `bit0`/`bit1` lemmas.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
OfNat instanceOfNat instance
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
Assume `[NeZero n]` instead of talking about `n+1`. This way we can reuse the raw natural literal `n` in `PNat.val_ofNat`. Also add `PNat.mk_ofNat` and drop some `bit0`/`bit1` lemmas.
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
Assume `[NeZero n]` instead of talking about `n+1`. This way we can reuse the raw natural literal `n` in `PNat.val_ofNat`. Also add `PNat.mk_ofNat` and drop some `bit0`/`bit1` lemmas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume
[NeZero n]instead of talking aboutn+1.This way we can reuse the raw natural literal
ninPNat.val_ofNat.Also add
PNat.mk_ofNatand drop somebit0/bit1lemmas.