Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Analysis/PSeries): simp for summable_nat_pow_inv #12423

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(Analysis/PSeries): simp for summable_nat_pow_inv #12423

wants to merge 2 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Apr 25, 2024

Open in Gitpod

@mo271
Copy link
Collaborator Author

mo271 commented Apr 25, 2024 •
edited

The loop described in https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/looping.20in.20.60simp.60.20set/near/361134234
seems to have been fixed:

import Mathlib.Analysis.SpecialFunctions.Pow.NNReal

example {p : ℕ} : Summable (fun n => (n ^ p)⁻¹ : ℕ → ℝ) := by
  simp -- simp made no progress

This removes one case of #10745

@mo271 mo271 added awaiting-review The author would like community review of the PR awaiting-CI labels Apr 25, 2024
mo271
mo271 commented Apr 26, 2024
View reviewed changes
Mathlib/Analysis/PSeries.lean Outdated Show resolved Hide resolved
Ruben-VandeVelde
Ruben-VandeVelde approved these changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@sgouezel
Copy link
Contributor

sgouezel commented May 5, 2024

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 5, 2024
@mo271
feat(Analysis/PSeries): simp for summable_nat_pow_inv (#12423)
abfb0e2 
Co-authored-by: Moritz Firsching <firsching@google.com>
@mathlib-bors
Copy link

mathlib-bors bot commented May 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Analysis/PSeries): simp for summable_nat_pow_inv [Merged by Bors] - feat(Analysis/PSeries): simp for summable_nat_pow_inv May 5, 2024
@mathlib-bors mathlib-bors bot closed this May 5, 2024
@mathlib-bors mathlib-bors bot deleted the mo271/simp_summable_nat_pow_inv branch May 5, 2024 13:38
apnelson1 pushed a commit that referenced this pull request May 12, 2024
@mo271 @apnelson1
feat(Analysis/PSeries): simp for summable_nat_pow_inv (#12423)
ce6821c 
Co-authored-by: Moritz Firsching <firsching@google.com>
callesonne pushed a commit that referenced this pull request May 16, 2024
@mo271 @callesonne
feat(Analysis/PSeries): simp for summable_nat_pow_inv (#12423)
2c25cf6 
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parcly-Taxel Parcly-Taxel Parcly-Taxel left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees
No one assigned
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mo271 @sgouezel @Parcly-Taxel @Ruben-VandeVelde