Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Axiomatise b ≠ 0 → a * b / b = a #12424

Closed
wants to merge 7 commits into from

Conversation

YaelDillies
Copy link
Collaborator

This lets us unify a few lemmas between GroupWithZero and EuclideanDomain and two lemmas that were previously proved separately for Nat, Int, Polynomial.


Open in Gitpod

This lets us unify a few lemmas between `GroupWithZero` and `EuclideanDomain` and two lemmas that were previously proved separately for `Nat`, `Int`, `Polynomial`.
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@riccardobrasca
Copy link
Member

!bench

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 27, 2024
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit d0ceeb7.
There were no significant changes against commit d700199.

mathlib-bors bot pushed a commit that referenced this pull request Apr 27, 2024
This lets us unify a few lemmas between `GroupWithZero` and `EuclideanDomain` and two lemmas that were previously proved separately for `Nat`, `Int`, `Polynomial`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Apr 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Axiomatise b ≠ 0 → a * b / b = a [Merged by Bors] - feat: Axiomatise b ≠ 0 → a * b / b = a Apr 27, 2024
@mathlib-bors mathlib-bors bot closed this Apr 27, 2024
@mathlib-bors mathlib-bors bot deleted the mul_div_cancel_class branch April 27, 2024 07:15
apnelson1 pushed a commit that referenced this pull request May 12, 2024
This lets us unify a few lemmas between `GroupWithZero` and `EuclideanDomain` and two lemmas that were previously proved separately for `Nat`, `Int`, `Polynomial`.
callesonne pushed a commit that referenced this pull request May 16, 2024
This lets us unify a few lemmas between `GroupWithZero` and `EuclideanDomain` and two lemmas that were previously proved separately for `Nat`, `Int`, `Polynomial`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants