Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(MeasureTheory): add CountablySeparated #12433

Closed
wants to merge 10 commits into from

Conversation

Felix-Weilacher
Copy link
Collaborator

@Felix-Weilacher Felix-Weilacher commented Apr 25, 2024

add a typeclass CountablySeparated _ abbreviating HasCountableSeparatingOn _ MeasurableSet univ. This is a common assumption is measure theory and is already used often in the library.

Additionally, mathlib was previously not consistent in choosing between the equivalent spellings HasCountableSeparatingOn X MeasurableSet s and HasCountableSeparatingOn s MeasurableSet univ for X a measurable space and s : Set X. (In the latter spelling, s is being coerced to the subtype of X.) Lemmas and instances are added to help unify the situation. This is now spelled CountablySeparated s.


Open in Gitpod

@Felix-Weilacher Felix-Weilacher added awaiting-review The author would like community review of the PR awaiting-CI t-measure-probability Measure theory / Probability theory and removed awaiting-CI labels Apr 25, 2024
Copy link
Contributor

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!

@RemyDegenne RemyDegenne added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 2, 2024
@Felix-Weilacher Felix-Weilacher added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 2, 2024
@Felix-Weilacher
Copy link
Collaborator Author

Thanks once again for taking a look!

@RemyDegenne
Copy link
Contributor

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 3, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 3, 2024
add a typeclass `CountablySeparated _` abbreviating `HasCountableSeparatingOn _ MeasurableSet univ`. This is a common assumption is measure theory and is already used often in the library. 

Additionally, mathlib was previously not consistent in choosing between the equivalent spellings `HasCountableSeparatingOn X MeasurableSet s` and `HasCountableSeparatingOn s MeasurableSet univ` for X a measurable space and `s : Set X`. (In the latter spelling, `s` is being coerced to the subtype of `X`.) Lemmas and instances are added to help unify the situation.  This is now spelled `CountablySeparated s`. 



Co-authored-by: Felix-Weilacher <112423742+Felix-Weilacher@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented May 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(MeasureTheory): add CountablySeparated [Merged by Bors] - feat(MeasureTheory): add CountablySeparated May 3, 2024
@mathlib-bors mathlib-bors bot closed this May 3, 2024
@mathlib-bors mathlib-bors bot deleted the countably_separated branch May 3, 2024 08:21
apnelson1 pushed a commit that referenced this pull request May 12, 2024
add a typeclass `CountablySeparated _` abbreviating `HasCountableSeparatingOn _ MeasurableSet univ`. This is a common assumption is measure theory and is already used often in the library. 

Additionally, mathlib was previously not consistent in choosing between the equivalent spellings `HasCountableSeparatingOn X MeasurableSet s` and `HasCountableSeparatingOn s MeasurableSet univ` for X a measurable space and `s : Set X`. (In the latter spelling, `s` is being coerced to the subtype of `X`.) Lemmas and instances are added to help unify the situation.  This is now spelled `CountablySeparated s`. 



Co-authored-by: Felix-Weilacher <112423742+Felix-Weilacher@users.noreply.github.com>
callesonne pushed a commit that referenced this pull request May 16, 2024
add a typeclass `CountablySeparated _` abbreviating `HasCountableSeparatingOn _ MeasurableSet univ`. This is a common assumption is measure theory and is already used often in the library. 

Additionally, mathlib was previously not consistent in choosing between the equivalent spellings `HasCountableSeparatingOn X MeasurableSet s` and `HasCountableSeparatingOn s MeasurableSet univ` for X a measurable space and `s : Set X`. (In the latter spelling, `s` is being coerced to the subtype of `X`.) Lemmas and instances are added to help unify the situation.  This is now spelled `CountablySeparated s`. 



Co-authored-by: Felix-Weilacher <112423742+Felix-Weilacher@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants