-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(MeasureTheory): add CountablySeparated #12433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felix-Weilacher
added
awaiting-review
The author would like community review of the PR
awaiting-CI
t-measure-probability
Measure theory / Probability theory
and removed
awaiting-CI
labels
Apr 25, 2024
RemyDegenne
reviewed
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good!
RemyDegenne
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
May 2, 2024
Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
Felix-Weilacher
added
awaiting-review
The author would like community review of the PR
awaiting-CI
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
May 2, 2024
Thanks once again for taking a look! |
Thanks! |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
May 3, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 3, 2024
add a typeclass `CountablySeparated _` abbreviating `HasCountableSeparatingOn _ MeasurableSet univ`. This is a common assumption is measure theory and is already used often in the library. Additionally, mathlib was previously not consistent in choosing between the equivalent spellings `HasCountableSeparatingOn X MeasurableSet s` and `HasCountableSeparatingOn s MeasurableSet univ` for X a measurable space and `s : Set X`. (In the latter spelling, `s` is being coerced to the subtype of `X`.) Lemmas and instances are added to help unify the situation. This is now spelled `CountablySeparated s`. Co-authored-by: Felix-Weilacher <112423742+Felix-Weilacher@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
feat(MeasureTheory): add CountablySeparated
[Merged by Bors] - feat(MeasureTheory): add CountablySeparated
May 3, 2024
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
add a typeclass `CountablySeparated _` abbreviating `HasCountableSeparatingOn _ MeasurableSet univ`. This is a common assumption is measure theory and is already used often in the library. Additionally, mathlib was previously not consistent in choosing between the equivalent spellings `HasCountableSeparatingOn X MeasurableSet s` and `HasCountableSeparatingOn s MeasurableSet univ` for X a measurable space and `s : Set X`. (In the latter spelling, `s` is being coerced to the subtype of `X`.) Lemmas and instances are added to help unify the situation. This is now spelled `CountablySeparated s`. Co-authored-by: Felix-Weilacher <112423742+Felix-Weilacher@users.noreply.github.com>
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
add a typeclass `CountablySeparated _` abbreviating `HasCountableSeparatingOn _ MeasurableSet univ`. This is a common assumption is measure theory and is already used often in the library. Additionally, mathlib was previously not consistent in choosing between the equivalent spellings `HasCountableSeparatingOn X MeasurableSet s` and `HasCountableSeparatingOn s MeasurableSet univ` for X a measurable space and `s : Set X`. (In the latter spelling, `s` is being coerced to the subtype of `X`.) Lemmas and instances are added to help unify the situation. This is now spelled `CountablySeparated s`. Co-authored-by: Felix-Weilacher <112423742+Felix-Weilacher@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has been sent to bors.
t-measure-probability
Measure theory / Probability theory
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a typeclass
CountablySeparated _
abbreviatingHasCountableSeparatingOn _ MeasurableSet univ
. This is a common assumption is measure theory and is already used often in the library.Additionally, mathlib was previously not consistent in choosing between the equivalent spellings
HasCountableSeparatingOn X MeasurableSet s
andHasCountableSeparatingOn s MeasurableSet univ
for X a measurable space ands : Set X
. (In the latter spelling,s
is being coerced to the subtype ofX
.) Lemmas and instances are added to help unify the situation. This is now spelledCountablySeparated s
.