[Merged by Bors] - fix(AlgebraicGeometry/GammaSpecAdjunction): speedup by adding universes #12469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!bench |
kbuzzard
commented
Apr 27, 2024
kbuzzard
added
awaiting-review
|
Here are the benchmark results for commit 037b868. Benchmark Metric Change
======================================================================
+ ~Mathlib.AlgebraicGeometry.GammaSpecAdjunction instructions -54.2% |
kbuzzard
commented
Apr 27, 2024
| @@ -460,7 +454,7 @@ theorem SpecΓIdentity_naturality {R S : CommRingCat} (f : R ⟶ S) : | |||
| (Scheme.Spec.map f.op).1.c.app (op ⊤) ≫ SpecΓIdentity.hom.app _ = | |||
| SpecΓIdentity.hom.app _ ≫ f := SpecΓIdentity.hom.naturality f | |||
|
|
|||
| theorem SpecΓIdentity_hom_app_presheaf_obj {X : Scheme} (U : Opens X) : | |||
| theorem SpecΓIdentity_hom_app_presheaf_obj {X : Scheme.{u}} (U : Opens X) : | |||
There was a problem hiding this comment.
Probably this one is worth stressing. I don't change the proof at all; I just make the universe explicit, and according to the profiler the total time taken on my machine goes from 0.7 secs to 0.23.
|
bors p=5 |
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 27, 2024
…es (#12469) Add some explicit universe annotations because they cause a speedup (currently an unexplained phenomenon, unfortunately). Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 28, 2024
Removes a porting note resolved by #12469; clarifies a porting note touched by it.
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
…es (#12469) Add some explicit universe annotations because they cause a speedup (currently an unexplained phenomenon, unfortunately). Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
Removes a porting note resolved by #12469; clarifies a porting note touched by it.
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
…es (#12469) Add some explicit universe annotations because they cause a speedup (currently an unexplained phenomenon, unfortunately). Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
Removes a porting note resolved by #12469; clarifies a porting note touched by it.
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some explicit universe annotations because they cause a speedup (currently an unexplained phenomenon, unfortunately).
Ok so I don't really know what's going on here. The Zulip thread is here, with Ruben reporting that on recent nightlies the compilation time for this file had got worse, and it was already bad. When doing some experiments I added some explicit universe annotations (not because I thought they would help -- it was literally just to make a diff smaller) and one declaration just magically got much much faster. So I put
set_option maxHeartbeats 20000(note: not 200000) at the top of the file, a couple more declarations broke, and I added explicit universe annotations in all of them and they all got fixed. It would be good to get some kind of explanation of what's going on here because the universe unification problem looks to me like it should be trivial: there is only one universe at play in this file and the answer to all the universe unifications questions I saw was "set?u.12345 = ?u.54321".In
comp_ring_hom_extI guess there was a possibility that Lean was ultimately deciding that both universes should be equal but taking some time over it, and now we just tell it to assume this (note that the change doesn't change the type of the declaration).