Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: update for leanprover/std4#758 #12475

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - chore: update for leanprover/std4#758 #12475

wants to merge 8 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Apr 28, 2024 •
edited by YaelDillies

@urkud urkud mentioned this pull request Apr 28, 2024
Merged
grunweg
grunweg approved these changes Apr 28, 2024
View reviewed changes
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thank you for doing this. (Pending the std PR and a std bump, of course.)

Mathlib/Data/List/Rotate.lean Outdated Show resolved Hide resolved
urkud
urkud commented Apr 28, 2024
View reviewed changes
Mathlib/Data/List/Rotate.lean Outdated Show resolved Hide resolved
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Apr 30, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 30, 2024
@urkud @semorrison
chore: update for leanprover-community/batteries#758 (#12475)
df69c16 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Apr 30, 2024

Build failed (retrying...):

@kmill
Copy link
Contributor

kmill commented Apr 30, 2024

bors r-

(requested at https://leanprover.zulipchat.com/#narrow/stream/345428-mathlib-reviewers/topic/bors.20fail/near/436232802)

@mathlib-bors
Copy link

mathlib-bors bot commented Apr 30, 2024

Canceled.

@semorrison
Copy link
Contributor

bors p=5

@semorrison
Copy link
Contributor

bors merge

mathlib-bors bot pushed a commit that referenced this pull request May 1, 2024
@urkud @semorrison
chore: update for leanprover-community/batteries#758 (#12475)
dc5d5b4 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented May 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: update for leanprover/std4#758 [Merged by Bors] - chore: update for leanprover/std4#758 May 1, 2024
@mathlib-bors mathlib-bors bot closed this May 1, 2024
@mathlib-bors mathlib-bors bot deleted the YK-for-std758 branch May 1, 2024 05:42
apnelson1 pushed a commit that referenced this pull request May 12, 2024
@urkud @semorrison @apnelson1
chore: update for leanprover-community/batteries#758 (#12475)
d3666a2 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
callesonne pushed a commit that referenced this pull request May 16, 2024
@urkud @semorrison @callesonne
chore: update for leanprover-community/batteries#758 (#12475)
789cbbe 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grunweg grunweg grunweg approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @semorrison @kmill @grunweg