-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: reduce imports in ZMod.Basic #12478
Conversation
Commenting to avoid duplicate work: I'm trying to pick this up. |
This is almost ready: there is one build error to fix in |
141373c
to
50caa40
Compare
@Ruben-VandeVelde I'd declare this done (modulo further build errors, but I cannot imagine those). Feel free to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parts I didn't do look good :)
import Mathlib.RingTheory.Ideal.Operations | ||
import Mathlib.Data.Fintype.Units | ||
import Mathlib.Data.Nat.Parity | ||
import Mathlib.Algebra.Ring.Prod | ||
import Mathlib.Tactic.FinCases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed, #12487 confirms this.
import Mathlib.Tactic.FinCases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably because it's imported transitively, because this file does use fin_cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also complained about the fact that shake
doesn't warn about transitive imports, but apparently that's supposed to be a feature. So I'll let you decide whether it's best to keep or remove.
Looks good to me otherwise, thanks!
bors d+
✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
- While at it, document the lemmas that were moved, and two similar lemmas in `ZMod.Basic`. Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de>
Build failed: |
@Ruben-VandeVelde This builds again :-) |
bors merge |
- While at it, document the lemmas that were moved, and two similar lemmas in `ZMod.Basic`. Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de>
Pull request successfully merged into master. Build succeeded: |
- While at it, document the lemmas that were moved, and two similar lemmas in `ZMod.Basic`. Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de>
- While at it, document the lemmas that were moved, and two similar lemmas in `ZMod.Basic`. Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de>
ZMod.Basic
.import Mathlib.RingTheory.ZMod
import inMathlib/Data/ZMod/Quotient.lean
andMathlib/NumberTheory/Padics/RingHoms.lean
is probably not too bad (shake didn't speak yet, so perhaps that is even superfluous).