Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat : port Algebra.Regular.Pow #1248

Closed
wants to merge 4 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Dec 28, 2022

Maybe I was lucky with my first port to mathlib4 or maybe I missed everything since no changes at all (except replacing Mathbin by Mathlib) were necessary for this port.

I must have done something wrong though since CI is failing in the check import phase and I don't know how to fix it.

Ok, I found out I need to add the file to Mathlib.lean....

@xroblot xroblot added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 28, 2022
@xroblot xroblot changed the title feat : port algebra.regular.pow feat : port Algebra.Regular.Pow Dec 28, 2022
@xroblot xroblot added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Dec 29, 2022
@xroblot xroblot added awaiting-review The author would like community review of the PR and removed awaiting-review The author would like community review of the PR labels Dec 29, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

bors d+

Mathlib/Algebra/Regular/Pow.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Dec 29, 2022

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Dec 29, 2022
Co-authored-by: Johan Commelin <johan@commelin.net>
@xroblot
Copy link
Collaborator Author

xroblot commented Dec 29, 2022

bors r+

bors bot pushed a commit that referenced this pull request Dec 29, 2022
Maybe I was lucky with my first port to mathlib4 or maybe I missed everything since no changes at all (except replacing `Mathbin` by `Mathlib`) were necessary for this port. 

~~I must have done something wrong though since CI is failing in the check import phase and I don't know how to fix it.~~

Ok, I found out I need to add the file to `Mathlib.lean`....
@bors
Copy link

bors bot commented Dec 29, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat : port Algebra.Regular.Pow [Merged by Bors] - feat : port Algebra.Regular.Pow Dec 29, 2022
@bors bors bot closed this Dec 29, 2022
@bors bors bot deleted the port/Algebra.Regular.Pow branch December 29, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants