-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Port Data.Rat.Sqrt #1252
Closed
aricursion
wants to merge
5
commits into
leanprover-community:master
from
aricursion:port/Data.Rat.Sqrt
Closed
[Merged by Bors] - feat: Port Data.Rat.Sqrt #1252
aricursion
wants to merge
5
commits into
leanprover-community:master
from
aricursion:port/Data.Rat.Sqrt
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruben-VandeVelde
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can tell without CI. Please ask for push access to the main repository on zulip, so you can make branches there going forward.
Ruben-VandeVelde
added
awaiting-review
The author would like community review of the PR
mathlib-port
This is a port of a theory file from mathlib.
labels
Dec 29, 2022
will do! |
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 29, 2022
Hi! This is my first port so I picked something pretty small. This is the initial commit where everything compiles properly, but I haven't looked at style guidelines super thoroughly yet. Please give any feedback that you have! Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat: Port Data.Rat.Sqrt
[Merged by Bors] - feat: Port Data.Rat.Sqrt
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-review
The author would like community review of the PR
mathlib-port
This is a port of a theory file from mathlib.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is my first port so I picked something pretty small. This is the initial commit where everything compiles properly, but I haven't looked at style guidelines super thoroughly yet. Please give any feedback that you have!