[Merged by Bors] - feat(Data/Matrix): Equalities relating mulVec and smul
#12538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Apr 30, 2024
eric-wieser
added
awaiting-author
eric-wieser
reviewed
Apr 30, 2024
eric-wieser
reviewed
Apr 30, 2024
trivial1711
reviewed
Apr 30, 2024
|
Hi, can you add a version for Matrix.scalar? |
Co-authored-by: Mitchell Lee <130885647+trivial1711@users.noreply.github.com>
Sure, working on it |
I don't think we want this, since |
Yes, good point. |
Rida-Hamadani
added
awaiting-review
eric-wieser
reviewed
Apr 30, 2024
eric-wieser
reviewed
May 1, 2024
|
bors d+ This looks great, thanks! I pushed some golfs and tweaked a name. Please merge once this passes CI :) |
|
✌️ Rida-Hamadani can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 2, 2024
These lemmas should make working with vectors easier in some cases. Check [this](https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/Factor.20out.20a.20vector) related Zulip topic. Co-authored-by: Rida Hamadani <106540880+Rida-Hamadani@users.noreply.github.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
mulVec and smulmulVec and smul
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
These lemmas should make working with vectors easier in some cases. Check [this](https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/Factor.20out.20a.20vector) related Zulip topic. Co-authored-by: Rida Hamadani <106540880+Rida-Hamadani@users.noreply.github.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
These lemmas should make working with vectors easier in some cases. Check [this](https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/Factor.20out.20a.20vector) related Zulip topic. Co-authored-by: Rida Hamadani <106540880+Rida-Hamadani@users.noreply.github.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lemmas should make working with vectors easier in some cases. Check this related Zulip topic.