[Merged by Bors] - chore: Rename Dart.is_adj to Dart.adj
#12574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `is` doesn't bring any information and `is_adj` really looks like a Lean 3-ism (even though it technically follows the Lean 4 naming convention).
YaelDillies
added
awaiting-review
2 tasks
eric-wieser
approved these changes
May 1, 2024
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
I have quite literally never heard anyone using that part of the library for anything else than the degree-sum formula, so I will claim it's fine to not deprecate🤞 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 1, 2024
The `is` doesn't bring any information and `is_adj` really looks like a Lean 3-ism (even though it technically follows the Lean 4 naming convention).
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Dart.is_adj to Dart.adjDart.is_adj to Dart.adj
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
The `is` doesn't bring any information and `is_adj` really looks like a Lean 3-ism (even though it technically follows the Lean 4 naming convention).
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
The `is` doesn't bring any information and `is_adj` really looks like a Lean 3-ism (even though it technically follows the Lean 4 naming convention).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isdoesn't bring any information andis_adjreally looks like a Lean 3-ism (even though it technically follows the Lean 4 naming convention).