[Merged by Bors] - chore(SimpleGraph/Regularity): Don't use Classical
#12575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The classical decidability instances were found in theorem statements, making them harder to use.
YaelDillies
added
awaiting-review
2 tasks
eric-wieser
reviewed
May 1, 2024
| @@ -105,7 +108,7 @@ private theorem distinctPairs_increment : | |||
|
|
|||
| private lemma pairwiseDisjoint_distinctPairs : | |||
| (P.parts.offDiag.attach : Set {x // x ∈ P.parts.offDiag}).PairwiseDisjoint | |||
| (distinctPairs G ε hP) := by | |||
There was a problem hiding this comment.
Is this argument ordering desirable? I think it's likely that the original non-use of variables was deliberate to affect the order.
There was a problem hiding this comment.
I will also note that "original" here means "written by 2021 me", so I don't feel too bad for impeding on myself!
leanprover-community-mathlib4-bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
ClassicalClassical
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classical decidability instances were found in theorem statements, making them harder to use.