Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: adaptations to lean 4.8.0 #12583

Closed
wants to merge 1 commit into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde commented May 1, 2024

Mainly this adds names to instances, which are presumably necessary for some unspecified reason.


Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label May 1, 2024
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an explanation of why all the instances were renamed?

The new names are fine, but I thought the new lean release was supposed to be better at naming them automatically; and it's strange to only give a name to one instance in a group of multiple.

(No changes needed to the diff, just a quick summary in the PR description is enough)

@eric-wieser
Copy link
Member

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented May 1, 2024

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels May 1, 2024
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label May 1, 2024
@semorrison
Copy link
Contributor

bors p=5

mathlib-bors bot pushed a commit that referenced this pull request May 1, 2024
Mainly this adds names to instances, which are presumably necessary for some unspecified reason.
@mathlib-bors
Copy link

mathlib-bors bot commented May 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: adaptations to lean 4.8.0 [Merged by Bors] - chore: adaptations to lean 4.8.0 May 1, 2024
@mathlib-bors mathlib-bors bot closed this May 1, 2024
@mathlib-bors mathlib-bors bot deleted the prep-v4.8.0-bis branch May 1, 2024 23:24
@kmill
Copy link
Contributor

kmill commented May 2, 2024

@eric-wieser I see a reason didn't make it in, but I'll record it here: there are a number of instances that are referred to in the docs, like the overview and the undergrad yaml files. The instance name changes (at least the ones I did) are giving the new names according to the new algorithm.

@Ruben-VandeVelde
Copy link
Collaborator Author

What Kyle said - and it's more robust to give explicit names when we're going to refer to them by name

@eric-wieser
Copy link
Member

Thanks! I was curious to know if the issue was name collisions in the new algorithm. I guess the answer is no?

apnelson1 pushed a commit that referenced this pull request May 12, 2024
Mainly this adds names to instances, which are presumably necessary for some unspecified reason.
callesonne pushed a commit that referenced this pull request May 16, 2024
Mainly this adds names to instances, which are presumably necessary for some unspecified reason.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants