-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: adaptations to lean 4.8.0 #12583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an explanation of why all the instances were renamed?
The new names are fine, but I thought the new lean release was supposed to be better at naming them automatically; and it's strange to only give a name to one instance in a group of multiple.
(No changes needed to the diff, just a quick summary in the PR description is enough)
bors d+ |
✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
bors p=5 |
Mainly this adds names to instances, which are presumably necessary for some unspecified reason.
Pull request successfully merged into master. Build succeeded: |
@eric-wieser I see a reason didn't make it in, but I'll record it here: there are a number of instances that are referred to in the docs, like the overview and the undergrad yaml files. The instance name changes (at least the ones I did) are giving the new names according to the new algorithm. |
What Kyle said - and it's more robust to give explicit names when we're going to refer to them by name |
Thanks! I was curious to know if the issue was name collisions in the new algorithm. I guess the answer is no? |
Mainly this adds names to instances, which are presumably necessary for some unspecified reason.
Mainly this adds names to instances, which are presumably necessary for some unspecified reason.
Mainly this adds names to instances, which are presumably necessary for some unspecified reason.