[Merged by Bors] - feat: more NNRat lemmas #12586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prove `(q ^ n).num = q.num ^ n` and `(q ^ n).den = q.den ^ n` by making those defeq. It is somewhat painful. `(q ^ n).den = q.den ^ n` is also defeq for `NNRat`, but not `(q ^ n).num = q.num ^ n` due to the `Int.natAbs` in the definition of `NNRat.num`.
…fScientific-lemma
…fScientific-lemma
eric-wieser
added
awaiting-review
Ruben-VandeVelde
approved these changes
May 5, 2024
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
YaelDillies
reviewed
May 5, 2024
YaelDillies
reviewed
May 5, 2024
YaelDillies
reviewed
May 5, 2024
Mathlib/Data/NNRat/Defs.lean
Outdated
| @@ -367,6 +367,7 @@ theorem natAbs_num_coe : (q : ℚ).num.natAbs = q.num := rfl | |||
|
|
|||
| lemma coprime_num_den (q : ℚ≥0) : q.num.Coprime q.den := by simpa [num, den] using Rat.reduced _ | |||
|
|
|||
| -- TODO: Rename `Rat.coe_nat_num`, `Rat.intCast_den`, `Rat.ofNat_num`, `Rat.ofNat_den` to match | |||
There was a problem hiding this comment.
Can you take the updated version I gave instead? Rat.coe_nat_num has already been renamed.
|
Back on the queue, then. maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
|
bors r+ |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 5, 2024
Note that the previous version of `Rat.ofScientific_eq_ofScientific` was not well-formed, as it did not include the necessary `ofNat`s. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
Note that the previous version of `Rat.ofScientific_eq_ofScientific` was not well-formed, as it did not include the necessary `ofNat`s. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
Note that the previous version of `Rat.ofScientific_eq_ofScientific` was not well-formed, as it did not include the necessary `ofNat`s. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the previous version of
Rat.ofScientific_eq_ofScientificwas not well-formed, as it did not include the necessaryofNats.Some steps towards