-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add constantCoeff_smul to RingTheory.PowerSeries.Basic #12616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
new-contributor
This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community!
label
May 3, 2024
Ruben-VandeVelde
approved these changes
May 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
sgouezel
reviewed
May 5, 2024
bors r+ |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
May 5, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 5, 2024
``` example : (constantCoeff ℝ) ((2:ℝ)•X) = 0 := by simp ``` simp doesn't solve the above because there is no lemma constantCoeff_smul tagged simp. This PR adds it to RingTheory.PowerSeries.Basic. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Add constantCoeff_smul to RingTheory.PowerSeries.Basic
[Merged by Bors] - Add constantCoeff_smul to RingTheory.PowerSeries.Basic
May 5, 2024
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
``` example : (constantCoeff ℝ) ((2:ℝ)•X) = 0 := by simp ``` simp doesn't solve the above because there is no lemma constantCoeff_smul tagged simp. This PR adds it to RingTheory.PowerSeries.Basic. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
``` example : (constantCoeff ℝ) ((2:ℝ)•X) = 0 := by simp ``` simp doesn't solve the above because there is no lemma constantCoeff_smul tagged simp. This PR adds it to RingTheory.PowerSeries.Basic. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintainer-merge
new-contributor
This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community!
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simp doesn't solve the above because there is no lemma constantCoeff_smul tagged simp. This PR adds it to RingTheory.PowerSeries.Basic.