Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add constantCoeff_smul to RingTheory.PowerSeries.Basic #12616

Closed
wants to merge 2 commits into from

Conversation

kcaze
Copy link
Collaborator

@kcaze kcaze commented May 3, 2024

example : (constantCoeff ℝ) ((2:ℝ)•X) = 0 := by simp

simp doesn't solve the above because there is no lemma constantCoeff_smul tagged simp. This PR adds it to RingTheory.PowerSeries.Basic.


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! label May 3, 2024
@kcaze kcaze added the awaiting-review The author would like community review of the PR label May 3, 2024
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

github-actions bot commented May 5, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@sgouezel
Copy link
Contributor

sgouezel commented May 5, 2024

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 5, 2024
```
example : (constantCoeff ℝ) ((2:ℝ)•X) = 0 := by simp
```
simp doesn't solve the above because there is no lemma constantCoeff_smul tagged simp. This PR adds it to RingTheory.PowerSeries.Basic.



Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@mathlib-bors
Copy link

mathlib-bors bot commented May 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title Add constantCoeff_smul to RingTheory.PowerSeries.Basic [Merged by Bors] - Add constantCoeff_smul to RingTheory.PowerSeries.Basic May 5, 2024
@mathlib-bors mathlib-bors bot closed this May 5, 2024
@mathlib-bors mathlib-bors bot deleted the kcaze/PowerSeries branch May 5, 2024 20:12
apnelson1 pushed a commit that referenced this pull request May 12, 2024
```
example : (constantCoeff ℝ) ((2:ℝ)•X) = 0 := by simp
```
simp doesn't solve the above because there is no lemma constantCoeff_smul tagged simp. This PR adds it to RingTheory.PowerSeries.Basic.



Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
callesonne pushed a commit that referenced this pull request May 16, 2024
```
example : (constantCoeff ℝ) ((2:ℝ)•X) = 0 := by simp
```
simp doesn't solve the above because there is no lemma constantCoeff_smul tagged simp. This PR adds it to RingTheory.PowerSeries.Basic.



Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants