Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - replay: #3604 for MonoidAlgebra #12646

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - replay: #3604 for MonoidAlgebra #12646

wants to merge 2 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented May 4, 2024

Weaken a couple of DistribSMul to SMulZero in MonoidAlgebra.

This parallels the analogous assumptions in the AddMonoidAlgebra instances that were weakened in #3604.

Found in the context of unifying AddMonoidAlgebra and MonoidAlgebra.

Open in Gitpod

@adomani adomani added the awaiting-review The author would like community review of the PR label May 4, 2024
@urkud
Copy link
Member

urkud commented May 4, 2024

Thanks! Once CI is happy, please merge this PR using bors r+
bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented May 4, 2024

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels May 4, 2024
@adomani
Copy link
Collaborator Author

adomani commented May 4, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request May 4, 2024
@adomani
replay: #3604 for MonoidAlgebra (#12646)
447d24f 
Weaken a couple of `DistribSMul` to `SMulZero` in `MonoidAlgebra`.

This parallels the analogous assumptions in the `AddMonoidAlgebra` instances that were weakened in #3604.

Found in the context of unifying `AddMonoidAlgebra` and `MonoidAlgebra`.
@mathlib-bors
Copy link

mathlib-bors bot commented May 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title replay: #3604 for MonoidAlgebra [Merged by Bors] - replay: #3604 for MonoidAlgebra May 4, 2024
@mathlib-bors mathlib-bors bot closed this May 4, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/DistribSMul_to_SMulZero branch May 4, 2024 06:45
@adomani adomani mentioned this pull request May 4, 2024
Draft
apnelson1 pushed a commit that referenced this pull request May 12, 2024
@adomani @apnelson1
replay: #3604 for MonoidAlgebra (#12646)
b6b61a9 
Weaken a couple of `DistribSMul` to `SMulZero` in `MonoidAlgebra`.

This parallels the analogous assumptions in the `AddMonoidAlgebra` instances that were weakened in #3604.

Found in the context of unifying `AddMonoidAlgebra` and `MonoidAlgebra`.
callesonne pushed a commit that referenced this pull request May 16, 2024
@adomani @callesonne
replay: #3604 for MonoidAlgebra (#12646)
44ce1e8 
Weaken a couple of `DistribSMul` to `SMulZero` in `MonoidAlgebra`.

This parallels the analogous assumptions in the `AddMonoidAlgebra` instances that were weakened in #3604.

Found in the context of unifying `AddMonoidAlgebra` and `MonoidAlgebra`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
delegated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adomani @urkud